1409170 - use official balrog stage environment for staging releases

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, enhancement)

Description

[[e-mail] (:bhearsum)]

We'll need to switch a few things:
- Any references to the public endpoint (should be aus4.stage.mozaws.net)
- Any references to the admin endpoint (should be balrog-admin.stage.mozaws.net)
- Any references to balrogVPNProxy (should be balrogStageVPNProxy)

Any tasks that use the proxy should continue to go through "http://balrog/api" to get at the stage admin host.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: parameterize balrog vpn proxy in releasetasks

Comment 2

[[e-mail] (:bhearsum)]

Attachment: pass along balrog_vpn_proxy in release runner

Comment 3

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8919037 [details] [diff] [review]
pass along balrog_vpn_proxy in release runner

Review of attachment 8919037 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good but is not enough. The `releasetasks_graph_gen.py` only takes care of:

* second graphs releases (like graphs we submit in the second week due to 5-days expiration)
* all Fennec releases (which are triggered by release-runner2.py which uses all these release-configs)

So we need to make more changes, to cover the "normal" releases. This happens because, once you amend the templates by introducing a new variable (e.g. `balrog_vpn_proxy`), you need to make sure it's present in bb-configs as well.

1) for production releases under https://hg.mozilla.org/build/buildbot-configs/file/default/mozilla/config.py (well, in this particular case, it's in fact https://dxr.mozilla.org/build-central/source/buildbot-configs/mozilla/production_config.py#50)

2) for staging releases under https://dxr.mozilla.org/build-central/source/buildbot-configs/mozilla/project_branches.py#416

Release runner consumes the info from bbconfigs and passes them to the jinja templates. So it needs to know of these beforehand. There are a few places to change:

a) add it here - see sample https://dxr.mozilla.org/build-central/source/tools/buildfarm/release/release-runner.py#481

b) (you already did) add it here - see sample https://dxr.mozilla.org/build-central/source/tools/buildfarm/release/releasetasks_graph_gen.py#52

c) add it here - both in the kwargs and in the dict within it - https://dxr.mozilla.org/build-central/source/tools/lib/python/kickoff/__init__.py#276

Comment 4

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8919036 [details] [review]
parameterize balrog vpn proxy in releasetasks

Made some comments in the PR. Basically, we can't merge this unless we land first the other tools/bbconfigs patches.

Comment 5

[[e-mail] (:bhearsum)]

Attachment: set balrog_vpn_proxy for old + new release runner

Comment 6

[[e-mail] (:bhearsum)]

Attachment: add balrog_vpn_proxy to buildbot-configs

I only ended up overriding this for jamun for now to avoid potentially messing up any work that's going on maple -- we should switch that too, once we're sure this works, and the change won't be disruptive to ongoing work there.

Comment 7

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Ben Hearsum (:bhearsum) from comment #6)
> Created attachment 8919330 [details] [diff] [review]
> add balrog_vpn_proxy to buildbot-configs
> 
> I only ended up overriding this for jamun for now to avoid potentially
> messing up any work that's going on maple -- we should switch that too, once
> we're sure this works, and the change won't be disruptive to ongoing work
> there.

Sgtm.

Comment 8

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8919036 [details] [review]
parameterize balrog vpn proxy in releasetasks

https://github.com/mozilla-releng/releasetasks/commit/3e6a09ae79d4dd8907cc449aba8309fd81b27113

+ deplyed in both bm83 and bm85.

Comment 9

[[e-mail] (:bhearsum)]

As far as I know this is done now - we've had multiple staging releases succesfully use balrog stage.