Closed Bug 1409260 Opened 6 years ago Closed 6 years ago

Remove remains of tc-vcs

Categories

(Firefox Build System :: Task Configuration, task)

Product:
Firefox Build System
Component:
Task Configuration
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla58

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(6 files)

Bug 1409260 - Remove base-repository exception in .taskcluster.yml.
59 bytes, text/x-review-board-request
dustin
: review+
Details
Bug 1409260 - Remove unused scripts from the desktop-build images.
59 bytes, text/x-review-board-request
dustin
: review+
Details
Bug 1409260 - Remove mozharness tc-vcs support.
59 bytes, text/x-review-board-request
jlund
: review+
Details
Bug 1409260 - Remove tc-vcs caches.
59 bytes, text/x-review-board-request
dustin
: review+
Details
Bug 1409260 - Remove tc-vcs related files from docker images.
59 bytes, text/x-review-board-request
dustin
: review+
Details
Bug 1409260 - Remove comments about tc-vcs.
59 bytes, text/x-review-board-request
dustin
: review+
Details 
AFAICT, tc-vcs is not used anymore. Time to get rid of the remains we have in the tree.
Depends on: 1383973
Comment on attachment 8919145 [details]
Bug 1409260 - Remove base-repository exception in .taskcluster.yml.

https://reviewboard.mozilla.org/r/190058/#review195382
Attachment #8919145 - Flags: review+
Comment on attachment 8919146 [details]
Bug 1409260 - Remove unused scripts from the desktop-build images.

https://reviewboard.mozilla.org/r/190060/#review195384
Attachment #8919146 - Flags: review+
Comment on attachment 8919147 [details]
Bug 1409260 - Remove mozharness tc-vcs support.

https://reviewboard.mozilla.org/r/190062/#review195386
Attachment #8919147 - Flags: review+
Comment on attachment 8919149 [details]
Bug 1409260 - Remove tc-vcs related files from docker images.

https://reviewboard.mozilla.org/r/190066/#review195390

::: taskcluster/docker/desktop-build/Dockerfile
(Diff revision 1)
>  MAINTAINER    Dustin J. Mitchell <dustin@mozilla.com>
>  
>  VOLUME /builds/worker/workspace
>  VOLUME /builds/worker/tooltool-cache
>  VOLUME /builds/worker/checkouts
> -VOLUME /builds/worker/.tc-vcs

Strictly speaking, the previous commit may have broken taskgraph until this commit because there is code that parses for VOLUME and ensures cache definitions are in sync. But as long as this all lands as a single push, we should be fine.
Attachment #8919149 - Flags: review+
Comment on attachment 8919150 [details]
Bug 1409260 - Remove comments about tc-vcs.

https://reviewboard.mozilla.org/r/190068/#review195392

Great cleanup!

FWIW my recollection was also that the android tasks were the last components using tc-vcs. Refactoring those was a bit difficult and I never had the will to do it. I'm glad nalexander tackled it as part of overhauling the android automation!

Also, with tc-vcs gone, I'm pretty sure we can remove node.js from some Docker images. Although with all the recent refactorings, I can't recall exactly where node.js is installed and what other functionality may be using it. IIRC there's a npm package related to tc-vcs that could almost certainly be removed without removing node.
Attachment #8919150 - Flags: review+
> IIRC there's a npm package related to tc-vcs that could almost certainly be removed without removing node.

There's one removed in taskcluster/docker/desktop1604-test/Dockerfile in one of the patches in this bug ;)
Also, it seems node is used for http/2 tests.
Comment on attachment 8919145 [details]
Bug 1409260 - Remove base-repository exception in .taskcluster.yml.

https://reviewboard.mozilla.org/r/190058/#review195504
Attachment #8919145 - Flags: review?(dustin) → review+
Comment on attachment 8919146 [details]
Bug 1409260 - Remove unused scripts from the desktop-build images.

https://reviewboard.mozilla.org/r/190060/#review195506
Attachment #8919146 - Flags: review?(dustin) → review+
Comment on attachment 8919148 [details]
Bug 1409260 - Remove tc-vcs caches.

https://reviewboard.mozilla.org/r/190064/#review195514

I'm grinning like a fool
Attachment #8919148 - Flags: review?(dustin) → review+
Comment on attachment 8919149 [details]
Bug 1409260 - Remove tc-vcs related files from docker images.

https://reviewboard.mozilla.org/r/190066/#review195516

::: taskcluster/docker/desktop1604-test/Dockerfile:76
(Diff revision 1)
>  RUN usermod -a -G video worker
>  
>  RUN mkdir Documents; mkdir Pictures; mkdir Music; mkdir Videos; mkdir artifacts
>  
> -# install tc-vcs and tc-npm-cache
> -RUN npm install -g taskcluster-vcs@2.3.12 \
> +# install tc-npm-cache
> +RUN  npm install -g taskcluster-npm-cache@1.1.14 \

I have no idea what this is, so best to leave it in. ..
Attachment #8919149 - Flags: review?(dustin) → review+
Comment on attachment 8919150 [details]
Bug 1409260 - Remove comments about tc-vcs.

https://reviewboard.mozilla.org/r/190068/#review195518
Attachment #8919150 - Flags: review?(dustin) → review+
Comment on attachment 8919149 [details]
Bug 1409260 - Remove tc-vcs related files from docker images.

https://reviewboard.mozilla.org/r/190066/#review195516

> I have no idea what this is, so best to leave it in. ..

Hrm, I vaguely recall that this was a b2g thing.
Comment on attachment 8919149 [details]
Bug 1409260 - Remove tc-vcs related files from docker images.

https://reviewboard.mozilla.org/r/190066/#review195516

> Hrm, I vaguely recall that this was a b2g thing.

taskcluster-vcs provided tc-vcs IIRC.

While I'm here, there's an outside chance that someone is relying on tc-vcs to perform Git-based automation on GitHub. I recall someone having such one-off automation ~1 year ago. Can't remember who. If that's still true, I suppose removing tc-vcs will shine a spotlight on them and enlighten all of us of their requirements.
Comment on attachment 8919149 [details]
Bug 1409260 - Remove tc-vcs related files from docker images.

https://reviewboard.mozilla.org/r/190066/#review195516

> taskcluster-vcs provided tc-vcs IIRC.
> 
> While I'm here, there's an outside chance that someone is relying on tc-vcs to perform Git-based automation on GitHub. I recall someone having such one-off automation ~1 year ago. Can't remember who. If that's still true, I suppose removing tc-vcs will shine a spotlight on them and enlighten all of us of their requirements.

Ah, I was referring to taskcluster-npm-cache.

I also recall some git automation using it, but we should probably be able to check some of our org repos for the use of it.  We can also audit the index service to see if it's being hit for those paths.
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 4841347dc20c -d 3915770a8869: rebasing 427140:4841347dc20c "Bug 1409260 - Remove base-repository exception in .taskcluster.yml. r=dustin,gps"
merging .taskcluster.yml
warning: conflicts while merging .taskcluster.yml! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/e325fb428095
Remove base-repository exception in .taskcluster.yml. r=dustin,gps
https://hg.mozilla.org/integration/autoland/rev/82781cec272f
Remove unused scripts from the desktop-build images. r=dustin,gps
https://hg.mozilla.org/integration/autoland/rev/b445d6f3372f
Remove mozharness tc-vcs support. r=dustin,gps
https://hg.mozilla.org/integration/autoland/rev/915021e13b67
Remove tc-vcs caches. r=dustin,gps
https://hg.mozilla.org/integration/autoland/rev/afb002c9c180
Remove tc-vcs related files from docker images. r=dustin,gps
https://hg.mozilla.org/integration/autoland/rev/4375412d40e3
Remove comments about tc-vcs. r=dustin,gps
Comment on attachment 8919147 [details]
Bug 1409260 - Remove mozharness tc-vcs support.

https://reviewboard.mozilla.org/r/190062/#review196078

lgtm
Attachment #8919147 - Flags: review?(jlund) → review+
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.