1409268 - PWA Badge and Onboarding - Add telemetry

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), enhancement, P1)

Description

[Nevin Chen(Not active on Bugzilla)]

We need telemetry for
1. Number of clicks on badge.
2. Number of clicks on pinned shortcut creation.
Please help add more if you think they are required.

Comment 1

[Nevin Chen(Not active on Bugzilla)]

3. Number of display for badge. (jcheng)

Comment 2

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1409268 - Add telemetry for pwa badge and oboarding usage.

Review commit: https://reviewboard.mozilla.org/r/190928/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/190928/

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8919981 [details]
Bug 1409268 - Add telemetry for pwa badge and oboarding usage.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/190928/diff/1-2/

Comment 4

[Max Liu [:maliu]]

Comment on attachment 8919981 [details]
Bug 1409268 - Add telemetry for pwa badge and oboarding usage.

https://reviewboard.mozilla.org/r/190928/#review197044

::: mobile/android/base/java/org/mozilla/gecko/toolbar/PwaConfirm.java:36
(Diff revision 2)
>      boolean isAnimating = false;
>  
>  
>      public static PwaConfirm show(Context context) {
> +
> +        Telemetry.sendUIEvent(TelemetryContract.Event.ACTION, TelemetryContract.Method.ACTIONBAR, "pwa_confirm_show");

Please avoid plain text in code. Move "pwa_confirm_xxx" to constant value for better trace/review process.

Comment 5

[Max Liu [:maliu]]

Comment on attachment 8919981 [details]
Bug 1409268 - Add telemetry for pwa badge and oboarding usage.

https://reviewboard.mozilla.org/r/190928/#review197058

::: mobile/android/base/java/org/mozilla/gecko/util/ShortcutUtils.java:36
(Diff revision 2)
>  import java.lang.reflect.Constructor;
>  
>  public class ShortcutUtils {
>      private static final String LOG_TAG = "ShortcutUtils";
>  
>      public static void createHomescreenIcon(final Intent shortcutIntent, final String aTitle,

Expanding all caller of this util method:"createHomescreenIcon"

* ShortcutUtils.createHomescreenIcon(Intent, String, String, Bitmap)
  * GeckoApplication.createShortcutWithIcon(String, String, Bitmap)

Are you sure you want to treat all shortcut creation(normal/PWA) as "pwa_confirm_added"?

Comment 6

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8919981 [details]
Bug 1409268 - Add telemetry for pwa badge and oboarding usage.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/190928/diff/2-3/

Comment 7

[Max Liu [:maliu]]

Comment on attachment 8919981 [details]
Bug 1409268 - Add telemetry for pwa badge and oboarding usage.

https://reviewboard.mozilla.org/r/190928/#review197110

::: mobile/android/base/java/org/mozilla/gecko/toolbar/PwaOnboarding.java:29
(Diff revision 3)
>  
>      static final String LINK_PWA_SUMO = "https://developer.mozilla.org/en-US/Apps/Progressive";
>  
>      public static void show(Context context) {
> +
> +        Telemetry.sendUIEvent(TelemetryContract.Event.ACTION, TelemetryContract.Method.DIALOG, "pwa_oboarding_show");

How about the plain text extra here?

Comment 8

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8919981 [details]
Bug 1409268 - Add telemetry for pwa badge and oboarding usage.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/190928/diff/3-4/

Comment 9

[Max Liu [:maliu]]

Comment on attachment 8919981 [details]
Bug 1409268 - Add telemetry for pwa badge and oboarding usage.

https://reviewboard.mozilla.org/r/190928/#review197112

::: mobile/android/base/java/org/mozilla/gecko/toolbar/PwaConfirm.java:31
(Diff revisions 2 - 3)
>  import org.mozilla.gecko.TelemetryContract;
>  import org.mozilla.gecko.webapps.WebAppManifest;
>  
>  public class PwaConfirm extends RelativeLayout {
>  
> -    boolean isAnimating = false;
> +    private static String TELEMETRY_EXTRA = "pwa_confirm";

If you want to concat extra(which I would suggest not to), please make it postfix with "_BASE".

::: mobile/android/base/java/org/mozilla/gecko/toolbar/PwaConfirm.java:32
(Diff revisions 2 - 3)
>  import org.mozilla.gecko.webapps.WebAppManifest;
>  
>  public class PwaConfirm extends RelativeLayout {
>  
> -    boolean isAnimating = false;
> +    private static String TELEMETRY_EXTRA = "pwa_confirm";
> +    private static String TELEMETRY_EXTRA_SHOW = TELEMETRY_EXTRA + "_confirm";

How come **pwa_confirm_show** become **pwa_confirm_confirm**?

Comment 10

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8919981 [details]
Bug 1409268 - Add telemetry for pwa badge and oboarding usage.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/190928/diff/4-5/

Comment 11

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8919981 [details]
Bug 1409268 - Add telemetry for pwa badge and oboarding usage.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/190928/diff/5-6/

Comment 12

[Max Liu [:maliu]]

Comment on attachment 8919981 [details]
Bug 1409268 - Add telemetry for pwa badge and oboarding usage.

https://reviewboard.mozilla.org/r/190928/#review197118

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2427f526608
Add telemetry for pwa badge and oboarding usage. r=maliu

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a2427f526608