Closed Bug 1409296 Opened 7 years ago Closed 7 years ago

Support minimal context menu functionality in GeckoView-based PWA

Categories

(Firefox for Android Graveyard :: Web Apps (PWAs), enhancement, P1)

Product:
Firefox for Android Graveyard
Component:
Web Apps (PWAs)
Version:
56 Branch
Type:
enhancement

Tracking

(firefox58 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 58
Tracking Flags:
Tracking Status
firefox58 --- verified

People

(Reporter: cnevinchen, Assigned: cnevinchen)

References

Details

(Whiteboard: [FNC][SPT58.3][INT][pwa-front-end] )

Attachments

(1 file)

Bug 1409296 - Support minimal context menu functionality in GeckoView-based PWA.
59 bytes, text/x-review-board-request
maliu
: review+
Details
Whiteboard: [pwa-front-end]
Priority: -- → P1
Comment on attachment 8919197 [details]
Bug 1409296 - Support minimal context menu functionality in GeckoView-based PWA.

https://reviewboard.mozilla.org/r/190110/#review195490

LGTM
Attachment #8919197 - Flags: review?(max) → review+
Pushed by nechen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/07d16d2791da
Support minimal context menu functionality in GeckoView-based PWA. r=maliu
https://hg.mozilla.org/mozilla-central/rev/07d16d2791da
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Hi snorp
This minimal context menu is similar to bug 1365868.
When I send out the patch, it worked. No sure why it's not working now.
Could you please help verify ?
Flags: needinfo?(snorp)
Dylan can you figure out what's going on here? Did we break context menu stuff in GV?
Flags: needinfo?(snorp) → needinfo?(droeh)
I've opened Bug 1411529 for this. I tested with yesterday's central. Custom Tab was also affected.
ok hopefully this is central only and not affecting Beta, let's follow up in bug 1411529.
See Also: → 1411529
Clearing NI since we're discussing this elsewhere.
Flags: needinfo?(droeh)
Whiteboard: [pwa-front-end] → [FNC][SPT58.3][INT][pwa-front-end]
Verified on Beta 58.
Status: RESOLVED → VERIFIED
status-firefox58: fixed → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: