Closed
Bug 1409296
Opened 7 years ago
Closed 7 years ago
Support minimal context menu functionality in GeckoView-based PWA
Categories
(Firefox for Android Graveyard :: Web Apps (PWAs), enhancement, P1)
Tracking
(firefox58 verified)
VERIFIED
FIXED
Firefox 58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | verified |
People
(Reporter: cnevinchen, Assigned: cnevinchen)
References
Details
(Whiteboard: [FNC][SPT58.3][INT][pwa-front-end] )
Attachments
(1 file)
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Whiteboard: [pwa-front-end]
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Updated•7 years ago
|
Priority: -- → P1
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8919197 [details]
Bug 1409296 - Support minimal context menu functionality in GeckoView-based PWA.
https://reviewboard.mozilla.org/r/190110/#review195490
LGTM
Attachment #8919197 -
Flags: review?(max) → review+
Pushed by nechen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/07d16d2791da
Support minimal context menu functionality in GeckoView-based PWA. r=maliu
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
|
|
Assignee | |
Comment 7•7 years ago
|
||
Hi snorp
This minimal context menu is similar to bug 1365868.
When I send out the patch, it worked. No sure why it's not working now.
Could you please help verify ?
Flags: needinfo?(snorp)
Dylan can you figure out what's going on here? Did we break context menu stuff in GV?
Flags: needinfo?(snorp) → needinfo?(droeh)
|
|
Assignee | |
Comment 9•7 years ago
|
||
I've opened Bug 1411529 for this. I tested with yesterday's central. Custom Tab was also affected.
|
|
||
Comment 10•7 years ago
|
||
ok hopefully this is central only and not affecting Beta, let's follow up in bug 1411529.
|
|
||
Updated•7 years ago
|
Whiteboard: [pwa-front-end] → [FNC][SPT58.3][INT][pwa-front-end]
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•