1409303 - Enable PWA by default

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), enhancement, P1)

Comment 1

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1409303 - Make PWA enable by default.

Review commit: https://reviewboard.mozilla.org/r/191002/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191002/

Comment 2

[Andreas Bovens [:abovens]]

This setting should be removed completely.
(Custom Tabs toggle on the other hand should be moved to Settings -> General)

Comment 3

[Nevin Chen(Not active on Bugzilla)]

(In reply to Andreas Bovens from comment #2)
> This setting should be removed completely.
You mean enable PWA by default and uses can't override it?

> (Custom Tabs toggle on the other hand should be moved to Settings -> General)
This is done in bug 1405236

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

for 58, I think we should have a setting given where we are with geckoview features.
if we are comfortable with the completeness of the geckoview offering, we can turn it on by default.
if it end up that we are on the edge, we have the option to turn it off by default and leave the choice to the users

Comment 5

[Andreas Bovens [:abovens]]

I'm not sure why a user would want to turn off PWA support, or why we wouldn't feel comfortable shipping our current implementation. Adding a PWA toggle to settings is overload, really.

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

Yeah I am not in favor of adding settings that basically amount to "unbreak my app". If the PWA feature isn't shippable, we shouldn't ship it.

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

if we feel comfortable with only P1s resolved for 58 in this sheet below, this means there will be web features that still don't work for 58 and it's fine to ship without the setting but I want to make sure that we make this decision while being aware that our implementation may have some feature missing comparing to other browsers.

https://docs.google.com/spreadsheets/d/1vwjPI9FGg-VmS_aMDQ95JQBtbDVupnzHn8vAxd7wKrA/edit#gid=0

Comment 8

[Wesly Huang (EPM)]

shall we make the final confirmation in tomorrow's weekly call? maybe @Andreas is in the timezone that will be able to join this week?

Comment 9

[Max Liu [:maliu]]

Comment on attachment 8920022 [details]
Bug 1409303 - Make PWA enable by default.

https://reviewboard.mozilla.org/r/191002/#review197120

Comment 10

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Wesly Huang (Fennec Frontend/Firefox EPM) from comment #8)
> shall we make the final confirmation in tomorrow's weekly call? maybe
> @Andreas is in the timezone that will be able to join this week?

We didn't talk about this last night, but I think we discussed things likely being in good shape, so I don't think we need this setting.

Comment 11

[Nevin Chen(Not active on Bugzilla)]

If we don't need this setting, we still need to make PWA enabled by default (that means we need to remove some code in a new patch)

Comment 12

[Wesly Huang (EPM)]

True, I thought we are in a good shape about P1s targeting 58 during the call (and still for now). However as Joe mentioned in comment 7 there are some web features don't work for 58 (e.g., P2/P3s) so I felt a final confirmation among us all would be good.

Now we have to land the patch for QA to start the test in time, so per Andreas' previous comment 5 and James' comment 10 we'll remove the setting directly (no any on/off switch) to make this feature simply available to all.

Nevin, as discussed please help on it, thank you!

(In reply to James Willcox (:snorp) ([e-mail]) from comment #10)
> (In reply to Wesly Huang (Fennec Frontend/Firefox EPM) from comment #8)
> > shall we make the final confirmation in tomorrow's weekly call? maybe
> > @Andreas is in the timezone that will be able to join this week?
> 
> We didn't talk about this last night, but I think we discussed things likely
> being in good shape, so I don't think we need this setting.

(In reply to Andreas Bovens from comment #5)
> I'm not sure why a user would want to turn off PWA support, or why we
> wouldn't feel comfortable shipping our current implementation. Adding a PWA
> toggle to settings is overload, really.

Comment 13

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8920022 [details]
Bug 1409303 - Make PWA enable by default.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191002/diff/1-2/

Comment 14

[Max Liu [:maliu]]

Comment on attachment 8920022 [details]
Bug 1409303 - Make PWA enable by default.

https://reviewboard.mozilla.org/r/191002/#review197930

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f67651c57b71
Make PWA enable by default. r=maliu

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f67651c57b71

Comment 17

[Oana Horvath [:ohorvath - out of office]]

Verified that the feature is now on by default. The setting is removed from the Advanced menu.
Build: Nightly 58.0a1 (2017-10-25).

Comment 19

[Andreas Bovens [:abovens]]

The "Experimental features" section in Advanced is now empty. Isn't it better to hide it completely if it doesn't contain any items?

Comment 20

[Nevin Chen(Not active on Bugzilla)]

The Experimental section is only in Nightly. We can absolutely hide it.

Comment 21

[Oana Horvath [:ohorvath - out of office]]

@abovens @nechen: There's already Bug 1411607 for that.