[Windows 7] Tabs don't get proper hover state in light theme

VERIFIED FIXED in Firefox 57

Status

()

defect
P1
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: johannh, Assigned: johannh)

Tracking

(Blocks 1 bug)

Trunk
Firefox 58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 unaffected, firefox57 verified, firefox58 verified)

Details

(Whiteboard: [reserve-photon-visual])

Attachments

(1 attachment)

When you hover over tabs in Windows 7 light theme, you can see some hover state appearing very faintly, but it's not what it should be.

I believe this has something to do with opacity, I can investigate.
Flags: qe-verify+
See Also: → 1409341
Comment on attachment 8919716 [details]
Bug 1409340 - Ensure light theme on Windows 7 gets dark hover state on tabs.

https://reviewboard.mozilla.org/r/190634/#review196260

::: browser/themes/windows/compacttheme.css:42
(Diff revision 1)
>      }
> +
> +    /* Because we're forcing the tabs toolbar to be [brighttext] to
> +     * get white toolbar button icons, we need to manually set the
> +     * correct color for the tab hover state for the light theme. */
> +    :root:-moz-lwtheme-darktext .tabbrowser-tab:hover > .tab-stack > .tab-background:not([selected=true]) {

:root:-moz-lwtheme-darktext doesn't make sense -- please move :-moz-lwtheme-darktext to .tab-background

::: browser/themes/windows/compacttheme.css:45
(Diff revision 1)
> +     * get white toolbar button icons, we need to manually set the
> +     * correct color for the tab hover state for the light theme. */
> +    :root:-moz-lwtheme-darktext .tabbrowser-tab:hover > .tab-stack > .tab-background:not([selected=true]) {
> +      background-color: rgba(0,0,0,.1) !important;
> +    }
> +    :root:-moz-lwtheme-darktext .tabbrowser-tab:hover > .tab-stack > .tab-background > .tab-line:not([selected=true]) {

and to .tab-line here
Attachment #8919716 - Flags: review?(dao+bmo) → review+
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/997c84dda1a6
Ensure light theme on Windows 7 gets dark hover state on tabs. r=dao
https://hg.mozilla.org/mozilla-central/rev/997c84dda1a6
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
I verified this issue using latest Nightly 58.0a1 with Build ID 20171022220103 on windows 7 x32.
I will mark this as verified fixed.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Do we need this fix in 57?
Flags: needinfo?(jhofmann)
Considering the low risk it's probably worth doing it, Windows 7 is a very popular platform and the light theme looks bad otherwise. I'll file for uplift, thanks for the reminder.
Flags: needinfo?(jhofmann)
Comment on attachment 8919716 [details]
Bug 1409340 - Ensure light theme on Windows 7 gets dark hover state on tabs.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1399498
[User impact if declined]: The light theme on Windows 7 has no visible hover state on tabs.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: Hover over tabs in light theme on Windows 7.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Nope
[Why is the change risky/not risky?]: It's adding two CSS rules that change the background color of tabs on hover. These rules are guaranteed to only apply to Windows 7 and light theme.
[String changes made/needed]: None
Attachment #8919716 - Flags: approval-mozilla-beta?
Comment on attachment 8919716 [details]
Bug 1409340 - Ensure light theme on Windows 7 gets dark hover state on tabs.

Recent regression, low risk fix, Beta57+
Attachment #8919716 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified as fixed on 57.0b14 Windows 7x64.
You need to log in before you can comment on or make changes to this bug.