1409438 - Silence unnecessary mutable variable warnings

Status: RESOLVED FIXED

(Testing :: geckodriver, defect)

Description

[Andreas Tolfsen ❲:ato❳]

From a build off mozilla-central with Rust stable:

> warning: variable does not need to be mutable
>    --> /home/ato/src/gecko/testing/webdriver/src/capabilities.rs:470:20
>     |
> 470 |                   |mut caps, (key, value)| {
>     |                    ^^^^^^^^
>     |
>     = note: #[warn(unused_mut)] on by default
> 
> warning: variable does not need to be mutable
>     --> src/marionette.rs:1459:13
>      |
> 1459 |         let mut stream = self.stream.as_mut().unwrap();
>      |             ^^^^^^^^^^
>      |
>      = note: #[warn(unused_mut)] on by default
> 
> warning: variable does not need to be mutable
>     --> src/marionette.rs:1461:17
>      |
> 1461 |             let mut buf = &mut [0 as u8];
>      |                 ^^^^^^^
> 
> warning: variable does not need to be mutable
>     --> src/marionette.rs:1483:13
>      |
> 1483 |         let mut buf = &mut [0 as u8; 8192];
>      |             ^^^^^^^

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1409438 - Make references to mutable variables immutable.

References to mutable variables do not need mutable themselves.

Review commit: https://reviewboard.mozilla.org/r/190204/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/190204/

Comment 2

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8919346 [details]
Bug 1409438 - Make references to mutable variables immutable.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/190204/diff/1-2/

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8919346 [details]
Bug 1409438 - Make references to mutable variables immutable.

https://reviewboard.mozilla.org/r/190204/#review195498

Please update the commit message so it says that you fix those warnings. Silencing gives a complete false meaning. First I thought you didn't want to let them show. It's good to see that you actually fixed them. 

Also for future patches please only change what you have to cover by the bug, and leave other stuff like refactorings to other bugs, or at least create another commit. Thanks.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8919346 [details]
Bug 1409438 - Make references to mutable variables immutable.

https://reviewboard.mozilla.org/r/190204/#review195500

::: commit-message-f2710:1
(Diff revision 2)
> +Bug 1409438 - Silence unnecessary mutable variable warnings. r?whimboo

Adding this issue so it's not getting lost by the review comment.

Comment 5

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8919346 [details]
Bug 1409438 - Make references to mutable variables immutable.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/190204/diff/2-3/

Comment 6

[Andreas Tolfsen ❲:ato❳]

(In reply to Henrik Skupin (:whimboo) from comment #3)

> Please update the commit message so it says that you fix those
> warnings.  Silencing gives a complete false meaning. First I
> thought you didn't want to let them show. It's good to see that
> you actually fixed them.

Fixed.

> Also for future patches please only change what you have to cover
> by the bug, and leave other stuff like refactorings to other bugs,
> or at least create another commit. Thanks.

I indented the code I touched but didn’t refactor anything?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d52b2b0c9387
Make references to mutable variables immutable. r=whimboo

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/d52b2b0c9387