1409448 - Check with -Wno-inline if any important functions don't get inlined

Status: NEW

(Core :: JavaScript Engine, enhancement, P3)

Description

[André Bargull [:anba]]

From time to time compilers don't inline or inline the wrong function. We could check with "-Wno-inline" if any important functions which we expect to be inlined actually don't get inlined by the compiler.


https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wno-inline

---
-Winline

    Warn if a function that is declared as inline cannot be inlined. Even with this option, the compiler does not warn about failures to inline functions declared in system headers.

    The compiler uses a variety of heuristics to determine whether or not to inline a function. For example, the compiler takes into account the size of the function being inlined and the amount of inlining that has already been done in the current function. Therefore, seemingly insignificant changes in the source program can cause the warnings produced by -Winline to appear or disappear.
---

Comment 1

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Move_fix-optionals