1409456 - Remove toolbox.options.key shortcut (CmdOrCtrl+Shift+O) to toggle devtools options panel

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

The CmdOrCtrl+Shift+O currently toggles devtools options. It's duplicated with F1 which does exactly the same thing.

Also the Debugger uses CmdOrCtrl+Shift+O to toggle function search, which is consistent with what the Chrome debugger does.

We should remove all usage of toolbox.options.key (or replace them with toolbox.help.key in tests) http://searchfox.org/mozilla-central/search?q=toolbox.options.key&case=true&path=

The following documentation pages should be updated:
- https://developer.mozilla.org/en-US/docs/Tools/Tools_Toolbox
- https://developer.mozilla.org/en-US/docs/Tools/Settings

Will open an issue on devtools-rfc to make sure everyone agrees.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1409456 - Remove CtrlOrCmd+Shift+O shortcut for DevTools options;

Review commit: https://reviewboard.mozilla.org/r/234476/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/234476/

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8965626 [details]
Bug 1409456 - Remove CtrlOrCmd+Shift+O shortcut for DevTools options;

https://reviewboard.mozilla.org/r/234476/#review240206

Code wise, this looks fine to me.  I agree though we should have an RFC or some other form of team discussion before landing.

Comment 3

[Julian Descottes [:jdescottes]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #2)
> Comment on attachment 8965626 [details]
> Bug 1409456 - Remove CtrlOrCmd+Shift+O shortcut for DevTools options;
> 
> https://reviewboard.mozilla.org/r/234476/#review240206
> 
> Code wise, this looks fine to me.  I agree though we should have an RFC or
> some other form of team discussion before landing.

Thanks for the review. I forgot to mention it here, but we did have a RFC for this:
https://github.com/devtools-html/rfcs/issues/23

and it was accepted, hence the patch :)

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Julian Descottes [:jdescottes][:julian] from comment #3)
> Thanks for the review. I forgot to mention it here, but we did have a RFC
> for this:
> https://github.com/devtools-html/rfcs/issues/23
> 
> and it was accepted, hence the patch :)

Hmm, which I also commented in... :S

Well, looks like we're good to go then.  I'll mark for docs update to remove the old shortcut.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0d0db94f501
Remove CtrlOrCmd+Shift+O shortcut for DevTools options;r=jryans

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/a0d0db94f501

Comment 7

[Chris Mills [:cmills]]

I've removed mention of the shortcut from the relevant pages:
https://developer.mozilla.org/en-US/docs/Tools/Keyboard_shortcuts
https://developer.mozilla.org/en-US/docs/Tools/Settings (the other page transcludes the information from here)

And added a note about the removal to the Fx61 rel notes:
https://developer.mozilla.org/en-US/Firefox/Releases/61#Developer_tools_2

Let me know if that looks OK. thanks!

Comment 8

[Julian Descottes [:jdescottes]]

Looks good for the shortcut removal! Thanks.