Closed Bug 1409456 Opened 2 years ago Closed 2 years ago
.options .key shortcut (Cmd Or Ctrl+Shift+O) to toggle devtools options panel
59 bytes, text/x-review-board-request
The CmdOrCtrl+Shift+O currently toggles devtools options. It's duplicated with F1 which does exactly the same thing. Also the Debugger uses CmdOrCtrl+Shift+O to toggle function search, which is consistent with what the Chrome debugger does. We should remove all usage of toolbox.options.key (or replace them with toolbox.help.key in tests) http://searchfox.org/mozilla-central/search?q=toolbox.options.key&case=true&path= The following documentation pages should be updated: - https://developer.mozilla.org/en-US/docs/Tools/Tools_Toolbox - https://developer.mozilla.org/en-US/docs/Tools/Settings Will open an issue on devtools-rfc to make sure everyone agrees.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Comment on attachment 8965626 [details] Bug 1409456 - Remove CtrlOrCmd+Shift+O shortcut for DevTools options; https://reviewboard.mozilla.org/r/234476/#review240206 Code wise, this looks fine to me. I agree though we should have an RFC or some other form of team discussion before landing.
Attachment #8965626 - Flags: review?(jryans) → review+
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #2) > Comment on attachment 8965626 [details] > Bug 1409456 - Remove CtrlOrCmd+Shift+O shortcut for DevTools options; > > https://reviewboard.mozilla.org/r/234476/#review240206 > > Code wise, this looks fine to me. I agree though we should have an RFC or > some other form of team discussion before landing. Thanks for the review. I forgot to mention it here, but we did have a RFC for this: https://github.com/devtools-html/rfcs/issues/23 and it was accepted, hence the patch :)
(In reply to Julian Descottes [:jdescottes][:julian] from comment #3) > Thanks for the review. I forgot to mention it here, but we did have a RFC > for this: > https://github.com/devtools-html/rfcs/issues/23 > > and it was accepted, hence the patch :) Hmm, which I also commented in... :S Well, looks like we're good to go then. I'll mark for docs update to remove the old shortcut.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/a0d0db94f501 Remove CtrlOrCmd+Shift+O shortcut for DevTools options;r=jryans
I've removed mention of the shortcut from the relevant pages: https://developer.mozilla.org/en-US/docs/Tools/Keyboard_shortcuts https://developer.mozilla.org/en-US/docs/Tools/Settings (the other page transcludes the information from here) And added a note about the removal to the Fx61 rel notes: https://developer.mozilla.org/en-US/Firefox/Releases/61#Developer_tools_2 Let me know if that looks OK. thanks!
Looks good for the shortcut removal! Thanks.
You need to log in before you can comment on or make changes to this bug.