Load CSD configuration from nsLookAndFeel

RESOLVED FIXED in Firefox 58

Status

()

enhancement
P1
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: stransky, Assigned: stransky)

Tracking

(Blocks 1 bug)

Trunk
mozilla58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

2 years ago
Allow CSD configuration loading from nsLookAndFeel.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 4

2 years ago
Jan, please set ircnick [1] to allow MozReview to recognize you...it seems to by confused by mail address I put there. Thanks!

[1] http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html#formatting-commit-messages-to-influence-behavior
Flags: needinfo?(jhorak)
(Assignee)

Updated

2 years ago
Attachment #8919423 - Flags: review?(jhorak)
Attachment #8919424 - Flags: review?(jhorak)
Attachment #8919425 - Flags: review?(jhorak)

Comment 5

2 years ago
mozreview-review
Comment on attachment 8919425 [details]
Bug 1409493 - Load actual CSD config from Gtk+,

https://reviewboard.mozilla.org/r/190250/#review196304

::: widget/gtk/nsLookAndFeel.cpp:1076
(Diff revision 1)
> +    }
> +
> +    if (sCSDAvailable) {
> +        static auto sGtkHeaderBarGetDecorationLayoutPtr =
> +          (const gchar* (*)(GtkWidget*))
> +          dlsym(RTLD_DEFAULT, "gtk_header_bar_get_decoration_layout");

nit: please fix indentation
(Assignee)

Updated

2 years ago
Priority: P3 → P1
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 9

2 years ago
mozreview-review
Comment on attachment 8919425 [details]
Bug 1409493 - Load actual CSD config from Gtk+,

https://reviewboard.mozilla.org/r/190250/#review197168
Attachment #8919425 - Flags: review?(jhorak) → review+

Comment 10

2 years ago
mozreview-review
Comment on attachment 8919424 [details]
Bug 1409493 - Implement CSD entries for Gtk+ LookAndFeel module,

https://reviewboard.mozilla.org/r/190248/#review197170
Attachment #8919424 - Flags: review?(jhorak) → review+

Comment 11

2 years ago
mozreview-review
Comment on attachment 8919423 [details]
Bug 1409493 - Add CSD entries to LookAndFeel,

https://reviewboard.mozilla.org/r/190246/#review197172
Attachment #8919423 - Flags: review?(jhorak) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 12

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/39534b033940
Add CSD entries to LookAndFeel, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/f9f7432faa25
Implement CSD entries for Gtk+ LookAndFeel module, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/9a7397c18137
Load actual CSD config from Gtk+, r=jhorak
Keywords: checkin-needed
(Assignee)

Updated

2 years ago
Flags: needinfo?(jhorak)
I noticed double-size titlebar buttons when I flip widget.allow-client-side-decoration. That's probably because I use a 4k screen and thus have enabled Hi-DPI(2x) UI scaling in my WM.

Is this something that's going to be addressed by the patches in bug 1283299 or should I file a separate issue for it?
(Assignee)

Comment 15

a year ago
(In reply to Tim Taubert [:ttaubert] from comment #14)
> I noticed double-size titlebar buttons when I flip
> widget.allow-client-side-decoration. That's probably because I use a 4k
> screen and thus have enabled Hi-DPI(2x) UI scaling in my WM.
> 
> Is this something that's going to be addressed by the patches in bug 1283299
> or should I file a separate issue for it?

Please file a new bug for it and add Jan (jhorak@redhat.com) there - he works on the hiDPI issues.
You need to log in before you can comment on or make changes to this bug.