1409493 - Load CSD configuration from nsLookAndFeel

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement, P1)

Description

[Martin Stránský [:stransky] (ni? me)]

Allow CSD configuration loading from nsLookAndFeel.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1409493 - Add CSD entries to LookAndFeel,

Review commit: https://reviewboard.mozilla.org/r/190246/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/190246/

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1409493 - Implement CSD entries for Gtk+ LookAndFeel module,

Review commit: https://reviewboard.mozilla.org/r/190248/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/190248/

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1409493 - Load actual CSD config from Gtk+,

Review commit: https://reviewboard.mozilla.org/r/190250/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/190250/

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Jan, please set ircnick [1] to allow MozReview to recognize you...it seems to by confused by mail address I put there. Thanks!

[1] http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html#formatting-commit-messages-to-influence-behavior

Comment 5

[Jan Horak [:jhorak]]

Comment on attachment 8919425 [details]
Bug 1409493 - Load actual CSD config from Gtk+,

https://reviewboard.mozilla.org/r/190250/#review196304

::: widget/gtk/nsLookAndFeel.cpp:1076
(Diff revision 1)
> +    }
> +
> +    if (sCSDAvailable) {
> +        static auto sGtkHeaderBarGetDecorationLayoutPtr =
> +          (const gchar* (*)(GtkWidget*))
> +          dlsym(RTLD_DEFAULT, "gtk_header_bar_get_decoration_layout");

nit: please fix indentation

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8919423 [details]
Bug 1409493 - Add CSD entries to LookAndFeel,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/190246/diff/1-2/

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8919424 [details]
Bug 1409493 - Implement CSD entries for Gtk+ LookAndFeel module,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/190248/diff/1-2/

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8919425 [details]
Bug 1409493 - Load actual CSD config from Gtk+,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/190250/diff/1-2/

Comment 9

[Jan Horak [:jhorak]]

Comment on attachment 8919425 [details]
Bug 1409493 - Load actual CSD config from Gtk+,

https://reviewboard.mozilla.org/r/190250/#review197168

Comment 10

[Jan Horak [:jhorak]]

Comment on attachment 8919424 [details]
Bug 1409493 - Implement CSD entries for Gtk+ LookAndFeel module,

https://reviewboard.mozilla.org/r/190248/#review197170

Comment 11

[Jan Horak [:jhorak]]

Comment on attachment 8919423 [details]
Bug 1409493 - Add CSD entries to LookAndFeel,

https://reviewboard.mozilla.org/r/190246/#review197172

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39534b033940
Add CSD entries to LookAndFeel, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/f9f7432faa25
Implement CSD entries for Gtk+ LookAndFeel module, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/9a7397c18137
Load actual CSD config from Gtk+, r=jhorak

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/39534b033940
https://hg.mozilla.org/mozilla-central/rev/f9f7432faa25
https://hg.mozilla.org/mozilla-central/rev/9a7397c18137

Comment 14

[Tim Taubert [:ttaubert] (inactive)]

I noticed double-size titlebar buttons when I flip widget.allow-client-side-decoration. That's probably because I use a 4k screen and thus have enabled Hi-DPI(2x) UI scaling in my WM.

Is this something that's going to be addressed by the patches in bug 1283299 or should I file a separate issue for it?

Comment 15

[Martin Stránský [:stransky] (ni? me)]

(In reply to Tim Taubert [:ttaubert] from comment #14)
> I noticed double-size titlebar buttons when I flip
> widget.allow-client-side-decoration. That's probably because I use a 4k
> screen and thus have enabled Hi-DPI(2x) UI scaling in my WM.
> 
> Is this something that's going to be addressed by the patches in bug 1283299
> or should I file a separate issue for it?

Please file a new bug for it and add Jan ([e-mail]) there - he works on the hiDPI issues.