Add static indexes to decision task

RESOLVED FIXED

Status

enhancement
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: rail, Assigned: rail)

Tracking

unspecified
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

2 years ago
Ship-it uses branch/revision combination to identify a revision we want to promote as a release. Releaserunner needs to find the corresponding decision task to start an action task. ATM we use only "latest" index for decision tasks. Let's add another one! :)
Assignee

Comment 1

2 years ago
Attachment #8919523 - Flags: feedback?(aki)

Comment 2

2 years ago
Comment on attachment 8919523 [details] [diff] [review]
decision_task_index.diff

I solved this by finding the revision in pushlog, and finding the pushlog id there: https://hg.mozilla.org/projects/maple/file/tip/taskcluster/taskgraph/actions/util.py#l34

I'm happier going by repo+revision though -- we can probably tear out the pushlog-id-finding-code if we get this landed :)
Attachment #8919523 - Flags: feedback?(aki) → feedback+
Comment hidden (mozreview-request)
Assignee

Comment 4

2 years ago
This worked fine on maple.

Comment 5

2 years ago
mozreview-review
Comment on attachment 8919556 [details]
Bug 1409577 - Add static indexes to decision task

https://reviewboard.mozilla.org/r/190396/#review195894

::: .taskcluster.yml:43
(Diff revision 1)
>      routes:
>        $if: 'tasks_for == "hg-push"'
>        then:
>          - "index.gecko.v2.${repository.project}.latest.firefox.decision"
> +        - "index.gecko.v2.${repository.project}.revision.${push.revision}.firefox.decision"
>          - "index.gecko.v2.${repository.project}.pushlog-id.${push.pushlog_id}.decision"

interesting that this one lacks `.firefox`.  Oh well :)
Attachment #8919556 - Flags: review?(dustin) → review+

Comment 6

2 years ago
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s b7a41ab4f564 -d 8fe459c1eaa7: rebasing 428149:b7a41ab4f564 "Bug 1409577 - Add static indexes to decision task r=dustin" (tip)
merging .taskcluster.yml
warning: conflicts while merging .taskcluster.yml! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 7

2 years ago
Pushed by raliiev@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/82ca05dc42e9
Add static indexes to decision task r=dustin
Assignee

Updated

2 years ago
Attachment #8919556 - Flags: checked-in+

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/82ca05dc42e9
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.