Closed Bug 140962 Opened 22 years ago Closed 22 years ago

Enter key to close out of Publish Progress dialog makes Composer unusable

Categories

(SeaMonkey :: Composer, defect)

Product:
SeaMonkey
Component:
Composer
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.0.1

People

(Reporter: dslmichael, Assigned: cmanske)

References

Details

(Keywords: dataloss, Whiteboard: publish [adt1 RTM][fixed in branch],custrtm-)

Attachments

(1 file)

patch v1
3.47 KB, patch
andreww
: review+
hewitt
: superreview+
Details | Diff | Splinter Review 
If you use the enter key to close out of the Publish Progress dialog, Composer
becomes unusable.

Steps to reproduce:
1. Launch Composer
2. Type some text
3. Publish the page to a valid FTP site
4. When the Publish Progress dialog is up, make sure to check the box for "Keep
this window open after publishing is complete" 
5. Hit the enter key on the keyboard to get rid of the dialog

Actual results:
You can no longer type or make any changes in Composer.

Expected results:
I would expect that the page still editable.

Reproduced on the 04-29 trunk, and 04-28 1.0.0 branch builds.
Attached patch patch v1 — — Splinter Review 
Good catch! It is *very* important that we always go through
"FinishPublishing()"
method and restore editing state in page. Unfortunately, if you don't designate

an "ondialogaccetpt" attribute in the dialog, it simply closes the window.
This fix suppresses closing progress dialog with Enter/Return key until 
publishing has finished. Then it sets default button to "Close" and allows 
Enter/Return to close the dialog properly.
Status: NEW → ASSIGNED
Keywords: nsbeta1, patch, review
Whiteboard: publish[adt2][FIX IN HAND][need r=,sr=]
Target Milestone: --- → mozilla1.0
Comment on attachment 81621 [details] [diff] [review]
patch v1

r=andreww
Attachment #81621 - Flags: review+
Keywords: nsbeta1 → nsbeta1+
Whiteboard: publish[adt2][FIX IN HAND][need r=,sr=] → publish[adt2 RTM][FIX IN HAND][need sr=]
Comment on attachment 81621 [details] [diff] [review]
patch v1

sr=hewitt
Attachment #81621 - Flags: superreview+
checked into trunk
EditorPublishProgress.js;
new revision: 1.6; previous revision: 1.5
done
EditorPublishProgress.xul;
new revision: 1.3; previous revision: 1.2
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Keywords: patch, review
Resolution: --- → FIXED
Whiteboard: publish[adt2 RTM][FIX IN HAND][need sr=] → publish[adt2 RTM]
Verified on 05-06 trunk build.
Status: RESOLVED → VERIFIED
adt1.0.0+ (on ADT's behalf) for approval to checkin to the 1.0 branch, pending
Drivers approval.  After, checking in, please add the fixed1.0 keyword.
Keywords: approval, dataloss
Whiteboard: publish[adt2 RTM] → publish [adt1 RTM] [Needs a=]
Blocks: 143047
Keywords: adt1.0.0+
changing to adt1.0.1+ for checkin to the 1.0 branch for the Mozilla1.0.1
milestone.  Please get drivers approval before checking in.
Keywords: adt1.0.0+ → adt1.0.1+
Whiteboard: publish [adt1 RTM] [Needs a=] → publish [adt1 RTM] [Needs a=],custrtm-
Keywords: mozilla1.0.1
Target Milestone: mozilla1.0 → mozilla1.0.1
a=chofmann for 1.0.1
Keywords: mozilla1.0.1 → mozilla1.0.1+
Whiteboard: publish [adt1 RTM] [Needs a=],custrtm- → publish [adt1 RTM]approved,custrtm-
checked into mozilla1.0.1 branch
Keywords: mozilla1.0.1+ → fixed1.0.1
Whiteboard: publish [adt1 RTM]approved,custrtm- → publish [adt1 RTM][fixed in trunk],custrtm-
verified in 6/4 branch build.
Keywords: verified1.0.1
Whiteboard: publish [adt1 RTM][fixed in trunk],custrtm- → publish [adt1 RTM][fixed in branch],custrtm-
removing fixed1.0.1 keyword
Keywords: fixed1.0.1
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: