140962 - Enter key to close out of Publish Progress dialog makes Composer unusable

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[michael wendell]

If you use the enter key to close out of the Publish Progress dialog, Composer
becomes unusable.

Steps to reproduce:
1. Launch Composer
2. Type some text
3. Publish the page to a valid FTP site
4. When the Publish Progress dialog is up, make sure to check the box for "Keep
this window open after publishing is complete" 
5. Hit the enter key on the keyboard to get rid of the dialog

Actual results:
You can no longer type or make any changes in Composer.

Expected results:
I would expect that the page still editable.

Reproduced on the 04-29 trunk, and 04-28 1.0.0 branch builds.

Comment 1

[Charles Manske]

Attachment: patch v1

Good catch! It is *very* important that we always go through
"FinishPublishing()"
method and restore editing state in page. Unfortunately, if you don't designate

an "ondialogaccetpt" attribute in the dialog, it simply closes the window.
This fix suppresses closing progress dialog with Enter/Return key until 
publishing has finished. Then it sets default button to "Close" and allows 
Enter/Return to close the dialog properly.

Comment 2

[andreww]

Comment on attachment 81621 [details] [diff] [review]
patch v1

r=andreww

Comment 3

[Joe Hewitt (gone)]

Comment on attachment 81621 [details] [diff] [review]
patch v1

sr=hewitt

Comment 4

[Charles Manske]

checked into trunk
EditorPublishProgress.js;
new revision: 1.6; previous revision: 1.5
done
EditorPublishProgress.xul;
new revision: 1.3; previous revision: 1.2

Comment 5

[michael wendell]

Verified on 05-06 trunk build.

Comment 6

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) for approval to checkin to the 1.0 branch, pending
Drivers approval.  After, checking in, please add the fixed1.0 keyword.

Comment 7

[scottputterman]

changing to adt1.0.1+ for checkin to the 1.0 branch for the Mozilla1.0.1
milestone.  Please get drivers approval before checking in.

Comment 8

[chris hofmann]

a=chofmann for 1.0.1

Comment 9

[Charles Manske]

checked into mozilla1.0.1 branch

Comment 10

[sujay]

verified in 6/4 branch build.

Comment 11

[sujay]

removing fixed1.0.1 keyword