1409670 - Clearkey example with clear start doesn't play on mac or linux

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Jean-Yves Avenard [:jya]]

STR:

1- open https://beaufortfrancois.github.io/sandbox/media/clearkey
2- select "H264 - Clear lead of 10s" in the drop down menu
3- Check the MSE box
4- Click on "Load & Play"

Expected: content play (it's video only)
Actual result: spinner, video never starts

It plays on Windows or on Chrome.

Comment 1

[James Cheng[:JamesCheng]]

keep ni?
I will investigate this issue.
Thanks.

Comment 2

[James Cheng[:JamesCheng]]

Attachment: Bug 1409670 - Skip decrypting request when receiving an unencrypted sample in Clearkey implementation.

Review commit: https://reviewboard.mozilla.org/r/191050/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191050/

Comment 3

[James Cheng[:JamesCheng]]

In our Clearkey decryption implementation, we don't consider the sample would be unencrypted.

So we decrypt a clear sample and lead to decrypting error from

http://searchfox.org/mozilla-central/rev/d0448c970093f94bd986a21d3a9e8c366b316eb4/media/gmp-clearkey/0.1/ClearKeyDecryptionManager.cpp#167,171

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8920051 [details]
Bug 1409670 - Skip decrypting request when receiving an unencrypted sample in Clearkey implementation.

https://reviewboard.mozilla.org/r/191050/#review196374

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58190ad9f36d
Skip decrypting request when receiving an unencrypted sample in Clearkey implementation. r=cpearce

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/58190ad9f36d