Closed Bug 1409680 Opened 2 years ago Closed 2 years ago
Conditionally disable Rust debug symbols
To keep memory usage low on 32bit hosts it maybe nice to provide a way to disable -C debuginfo=2.
Downstream FreeBSD keeps non-debug symbols for profiling (dtrace, pmcstat) and quick stacktraces. Since Rust dependency was introduced libxul.so grew in size for no good reason (Firefox is mostly C++). And Stylo will bump the size even more. Such use case is probably less common than simply stripping the binary.
Comment on attachment 8919676 [details] Bug 1409680 - Extend --disable-debug-symbols to Rust code. Allows me to build m-c with stylo and webrender on OpenBSD/i386, using --disable-debug-symbols.
Attachment #8919676 - Flags: feedback+
Comment on attachment 8919676 [details] Bug 1409680 - Extend --disable-debug-symbols to Rust code. https://reviewboard.mozilla.org/r/190588/#review196206
Attachment #8919676 - Flags: review?(mh+mozilla) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/19a66220f57c Extend --disable-debug-symbols to Rust code. r=glandium
Approval Request Comment [Feature/Bug causing the regression]: bug 1283898 but bug 1342450 and bug 1356991 made it worse [User impact if declined]: --disable-debug-symbols builds on 32bit hosts may run out of memory and fail (see bug 1401093). The resulting package wastes ~70Mb of space for incomplete debug symbols (i.e., Rust but not C++) unless stripped. [Is this code covered by automated tests?]: AFAIK, --disable-debug-symbols isn't used by automation at all. [Has the fix been verified in Nightly?]: Yes, also on FF57 downstream. Automation build logs contain -C debuginfo=2 as before. [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: Can either break build or unintentionally disable Rust debug symbols (e.g., used to show source lines in stacktraces). [String changes made/needed]: None
Attachment #8920531 - Flags: approval-mozilla-beta?
Comment on attachment 8920531 [details] [diff] [review] rebased for Firefox 57 https://treeherder.mozilla.org/#/jobs?repo=try&revision=ddfe1d34783c
Comment on attachment 8920531 [details] [diff] [review] rebased for Firefox 57 makes sense, Beta57+
Attachment #8920531 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.