1409750 - Add XCUITests for the new shortcuts implemented

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, enhancement)

Description

[Isabel Rios[:isabel_rios]]

These are the new shortcuts:

long press the tabs button
- Open a new Tab
- Open a new Private tab

Long press page options
- show share sheet

Please see bug 1407455. It may be worth to have tests for this.

Comment 1

[Joe G]

Agreed! I’ll try and add those

Comment 2

[Isabel Rios[:isabel_rios]]

In iPad the behaviour would be different, no shortcuts when long pressing the tabs button. See bug 1409686.

Thanks Joe! I almost have a first version of XCUITests already for this implementation, will share soon and you can comment, add more tests or whatever :) or if you have something already, pelase let me know. Thanks!

Comment 3

[Isabel Rios[:isabel_rios]]

Attachment: Pull Request

Tests added in TopTabs Suite:
(only iphone)
-Add tab by long press on tabs button
-Add private tab by long press on tabs button
Test added in PhotonActionSheetUI Suite:
(iphone and ipad)
-Open share menu by long press on page options button

Comment 4

[Joe G]

Thanks Isabel! This looks great.

Comment 5

[Isabel Rios[:isabel_rios]]

Comment on attachment 8920157 [details] [review]
Pull Request

Tests are passing: 
https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/59e8c5280c58fe0001dd38c3#tests
(thre failing ones are regarding Navigation that already solved in latest master)

Comment 6

[Isabel Rios[:isabel_rios]]

Merged https://github.com/mozilla-mobile/firefox-ios/commit/9f46cedf718d5c5089a9398c29ef72ada805474b

Comment 7

[Isabel Rios[:isabel_rios]]

Uplifted to v10.x