1409845 - Add GetLCIDFromLangListNodeWithLICCheck to the socorro skip list

Status: RESOLVED FIXED

(Socorro :: Processor, task, P2)

Description

[Jim Mathies [:jimm]]

GetLCIDFromLangListNodeWithLICCheck triggers the end of traversal yet the detail for these signatures is farther down the stack:

https://crash-stats.mozilla.com/search/?signature=%3DRtlpWaitOnCriticalSection%20%7C%20GetLCIDFromLangListNodeWithLICCheck&product=Firefox&date=%3E%3D2017-09-01T19%3A19%3A00.000Z&date=%3C2017-10-18T19%3A19%3A00.000Z&_sort=-date&_facets=signature&_facets=accessibility&_facets=accessibility_in_proc_client&_facets=process_type&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#crash-reports

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Making this a P1. I'll try to get to it soon.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Oops--this should be a P2. Sorry about that.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Example crashes:

https://crash-stats.mozilla.com/report/index/75012c53-2d7d-467d-872d-e08560171018

https://crash-stats.mozilla.com/report/index/ffdd2389-6d9a-4403-be42-b32c50171018

Jim: Just to make sure, do you want signature generation to include GetLCIDFromLangListNodeWithLICCheck in the signature, but continue to the next frame or do you want signature generation to ignore GetLCIDFromLangListNodeWithLICCheck altogether?

Comment 4

[Jim Mathies [:jimm]]

(In reply to Will Kahn-Greene [:willkg] ET needinfo? me from comment #3)
> Example crashes:
> 
> https://crash-stats.mozilla.com/report/index/75012c53-2d7d-467d-872d-
> e08560171018
> 
> https://crash-stats.mozilla.com/report/index/ffdd2389-6d9a-4403-be42-
> b32c50171018
> 
> Jim: Just to make sure, do you want signature generation to include
> GetLCIDFromLangListNodeWithLICCheck in the signature, but continue to the
> next frame or do you want signature generation to ignore
> GetLCIDFromLangListNodeWithLICCheck altogether?

ignore it altogether seems best - 

https://crash-stats.mozilla.com/search/?signature=~GetLCIDFromLangListNodeWithLICCheck&product=Firefox&date=%3E%3D2017-10-15T14%3A14%3A00.000Z&date=%3C2017-10-22T14%3A14%3A00.000Z&_sort=-date&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-signature

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Adding GetLCIDFromLangListNodeWithLICCheck to the irrelevant list yields this:

you@processor:/app$ python -m socorro.signature 75012c53-2d7d-467d-872d-e08560171018 ffdd2389-6d9a-4403-be42-b32c50171018
Crash id: 75012c53-2d7d-467d-872d-e08560171018
Original: RtlpWaitOnCriticalSection | GetLCIDFromLangListNodeWithLICCheck
New:      RtlpWaitOnCriticalSection | msmpeg2vdec.dll@0xc513b
Same?:    False

Crash id: ffdd2389-6d9a-4403-be42-b32c50171018
Original: RtlpWaitOnCriticalSection | GetLCIDFromLangListNodeWithLICCheck
New:      RtlpWaitOnCriticalSection | npjp2.dll@0x3705
Same?:    False


Jim: Does that look like what you're expecting?

Comment 6

[Jim Mathies [:jimm]]

for those reports, yes.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4058: fix bug 1409845 - add GetLCIDFromLangListNodeWithLICCheck to irrelevant list

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/133307e17759e76b18fabad6faec783777a84b79
fix bug 1409845 - add GetLCIDFromLangListNodeWithLICCheck to irrelevant list

https://github.com/mozilla-services/socorro/commit/050ab80edf5f802c89be656b20605713e57a088d
Merge pull request #4058 from willkg/1409845-getlcidfromlanglistnodewithlicchecklollerskates

fixes bug 1409845 - add GetLCIDFromLangListNodeWithLICCheck to irrelevant list