MinGW's IDWriteFontFace1 is broken

RESOLVED FIXED in Firefox 58

Status

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: tjr, Assigned: tjr)

Tracking

(Blocks: 1 bug)

Trunk
mozilla58

Firefox Tracking Flags

(firefox58 fixed)

Details

(Whiteboard: [tor])

Attachments

(1 attachment)

(Assignee)

Description

a year ago
See https://bugzilla.mozilla.org/show_bug.cgi?id=1372958#c10

Jacek commited a patch, we just need to bump the MinGW version.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

a year ago
mozreview-review
Comment on attachment 8919943 [details]
Bug 1409915 Bump MinGW version to fix a broken IDWriteFontFace1 declaration

https://reviewboard.mozilla.org/r/190884/#review196084
Attachment #8919943 - Flags: review?(nfroyd) → review+
(Assignee)

Updated

a year ago
Keywords: checkin-needed

Comment 4

a year ago
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e75759bfeb32
Bump MinGW version to fix a broken IDWriteFontFace1 declaration r=froydnj
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e75759bfeb32
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
I can't tell if I'm reading the source history on sf correctly... does your change also fix IDWriteFontFace2 in dwrite_2.h?
Flags: needinfo?(jacek)

Comment 7

a year ago
Ah, right, GetMetrics should be changed there too. Good catch. (Duplicated GetMetrics is relevant only for C, not for C++, so as far as Mozilla is considered, it should be fine).
Flags: needinfo?(jacek)

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.