Closed
Bug 1409915
Opened 7 years ago
Closed 7 years ago
MinGW's IDWriteFontFace1 is broken
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
(Blocks 1 open bug)
Details
(Whiteboard: [tor])
Attachments
(1 file)
See https://bugzilla.mozilla.org/show_bug.cgi?id=1372958#c10 Jacek commited a patch, we just need to bump the MinGW version.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8919943 [details] Bug 1409915 Bump MinGW version to fix a broken IDWriteFontFace1 declaration https://reviewboard.mozilla.org/r/190884/#review196084
Attachment #8919943 -
Flags: review?(nfroyd) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e75759bfeb32 Bump MinGW version to fix a broken IDWriteFontFace1 declaration r=froydnj
Keywords: checkin-needed
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e75759bfeb32
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
I can't tell if I'm reading the source history on sf correctly... does your change also fix IDWriteFontFace2 in dwrite_2.h?
Flags: needinfo?(jacek)
Comment 7•7 years ago
|
||
Ah, right, GetMetrics should be changed there too. Good catch. (Duplicated GetMetrics is relevant only for C, not for C++, so as far as Mozilla is considered, it should be fine).
Flags: needinfo?(jacek)
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•