1409916 - [e10s a11y] Eliminate pointless cross-proc call for IA2_2::attribute

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement)

Description

[James Teh [:Jamie]]

As noted in bug 1363595 comment 24, IAccessible2_2::get_attribute is not implemented yet in Gecko. However, the handler still passes this through, thus resulting in a pointless cross-process call. We should just return E_NOTIMPL in the handler for this method. JAWS calls this quite a bit, and the more cross-proc calls we can eliminate, the better for perf.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1409916: Eliminate pointless cross-process call for IAccessible2_2::get_attribute.

IAccessible2_2::get_attribute is not implemented yet in Gecko.
However, the handler still passes this through, thus resulting in a pointless cross-process call.
Instead, just return E_NOTIMPL in the handler for this method.

Review commit: https://reviewboard.mozilla.org/r/190888/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/190888/

Comment 2

[James Teh [:Jamie]]

Forgot to note that this depends on the patches from bug 1363595.

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8919944 [details]
Bug 1409916: Eliminate pointless cross-process call for IAccessible2_2::get_attribute.

https://reviewboard.mozilla.org/r/190888/#review198740

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

(I'm going to hold off adding aes+ to the rest of the cache perf work pending discussion how we want to track it all)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/681b41afb3ee
Eliminate pointless cross-process call for IAccessible2_2::get_attribute. r=aklotz

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/681b41afb3ee