Closed Bug 1409916 Opened 3 years ago Closed 3 years ago

[e10s a11y] Eliminate pointless cross-proc call for IA2_2::attribute

Categories

(Core :: Disability Access APIs, enhancement)

All
Windows
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: Jamie, Assigned: Jamie)

References

Details

(Whiteboard: [aes+])

Attachments

(1 file)

As noted in bug 1363595 comment 24, IAccessible2_2::get_attribute is not implemented yet in Gecko. However, the handler still passes this through, thus resulting in a pointless cross-process call. We should just return E_NOTIMPL in the handler for this method. JAWS calls this quite a bit, and the more cross-proc calls we can eliminate, the better for perf.
Forgot to note that this depends on the patches from bug 1363595.
Comment on attachment 8919944 [details]
Bug 1409916: Eliminate pointless cross-process call for IAccessible2_2::get_attribute.

https://reviewboard.mozilla.org/r/190888/#review198740
Attachment #8919944 - Flags: review?(aklotz) → review+
(I'm going to hold off adding aes+ to the rest of the cache perf work pending discussion how we want to track it all)
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/681b41afb3ee
Eliminate pointless cross-process call for IAccessible2_2::get_attribute. r=aklotz
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/681b41afb3ee
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.