1409967 - Adds an initial react/redux template for loading a flexbox accordion in the Layout panel

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement)

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1409967 - Adds an initial react/redux template for loading a flexbox accordion in the Layout panel.

Review commit: https://reviewboard.mozilla.org/r/190978/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/190978/

Comment 2

[Patrick Brosset <:pbro>]

Comment on attachment 8920008 [details]
Bug 1409967 - Adds an initial react/redux template for loading a flexbox accordion in the Layout panel.

https://reviewboard.mozilla.org/r/190978/#review196660

The boilerplate code looks good to me! 
But we need to actually use the devtools.flexboxinspector.enabled pref.

::: devtools/client/inspector/layout/components/App.js:64
(Diff revision 1)
> +            header: LAYOUT_L10N.getStr("flexbox.header"),
> +            component: Flexbox,
> +            componentProps: this.props,
> +            opened: Services.prefs.getBoolPref(FLEXBOX_OPENED_PREF),
> +            onToggled: () => {
> +              let opened =  Services.prefs.getBoolPref(FLEXBOX_OPENED_PREF);
> +              Services.prefs.setBoolPref(FLEXBOX_OPENED_PREF, !opened);
> +            }
> +          },

I thought the whole thing would be behind a pref. Here the pref controls whether the accordion item is opened or closed, but not whether the whole feature itself is enabled or disabled for our users.
It should be disabled by default, until we polish the actor perf and come up with a definitive UI.

::: devtools/client/preferences/devtools.js:65
(Diff revision 1)
>  pref("devtools.inspector.colorWidget.enabled", false);
>  // Enable the CSS shapes highlighter
>  pref("devtools.inspector.shapesHighlighter.enabled", true);
>  
> +// Enable the Flexbox Inspector
> +pref("devtools.flexboxinspector.enabled", false);

Ah, here is the pref. Although I don't see it being used in this patch.

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8920008 [details]
Bug 1409967 - Adds an initial react/redux template for loading a flexbox accordion in the Layout panel.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/190978/diff/1-2/

Comment 4

[Patrick Brosset <:pbro>]

Comment on attachment 8920008 [details]
Bug 1409967 - Adds an initial react/redux template for loading a flexbox accordion in the Layout panel.

https://reviewboard.mozilla.org/r/190978/#review198178

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/53967c00d476
Adds an initial react/redux template for loading a flexbox accordion in the Layout panel. r=pbro

Comment 6

[Attila Craciun [:arny]]

https://hg.mozilla.org/mozilla-central/rev/53967c00d476