1409992 - <img> in <foreignObject> doesn't render when in <img>

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Kaiido]

Attachment: img-fO.html

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171016185129

Steps to reproduce:

Take an svg document with this simple structure:
<svg width...>
 <foreignObject width...>
   <img src="data:image/...>


Actual results:

When this svg document is displayed in an <img> (HTMLImage) the foreignObject's img won't display.
It does work well when this document is loaded directly or through an iframe etc.


Expected results:

The img should load, whatever the svg's container.
Ps: (not sure if SVG is the right component since the bug seems to be in HTMLImage)

Comment 1

[Robert Longson [:longsonr]]

This is a regression. A build from 2013-01-01 works for instance.

Comment 2

[Kaiido]

Yes indeed it is a regression.

Here are my mozregression results:

First step:
Last good revision: 8e98dab5054dd093a37ba20c62cf0523e484cfbd (2017-05-19)
First bad revision: 8d60d0f825110cfb646ac31dc16dc011708bcf34 (2017-05-20)

Second step: 
FO: Last good revision: 52b207e50972b74546b89775b6dd7c182ff6ff6a
First bad revision: c800b6dfca673f8cb0f3cf41e4f495755d04bbb3

Last step:
Last good revision: 1667def6751501149dc69e7d9608cffdf3c19e7d
First bad revision: 55ccbc9a9bfcd1327f617230031f178a7a2aa8d3

Comment 3

[Cameron McCormack (:heycam)]

In that inbound merge https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=c800b6dfca67 it's probably bug 1318624.

Comment 4

[Cameron McCormack (:heycam)]

My guess is that the places in the bug 1318624 patch where we call IsCurrentActiveDocument() we should also allow IsBeingUsedAsImage().

Comment 5

[Cameron McCormack (:heycam)]

Attachment: Bug 1409992 - Allow SVG as images to load data: URL images.

Review commit: https://reviewboard.mozilla.org/r/191076/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191076/

Comment 6

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=254b77c6f1ca4f64bcb9707ff6ed693e0ff18a63

Comment 7

[Edgar Chen [:edgar]]

Comment on attachment 8920074 [details]
Bug 1409992 - Allow SVG as images to load data: URL images.

https://reviewboard.mozilla.org/r/191076/#review196644

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/725b9a93a191
Allow SVG as images to load data: URL images. r=edgar

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for frequently failing layout/reftests/svg/foreignObject-img.html:

https://hg.mozilla.org/integration/autoland/rev/3b598784dfd30d89c447cabe5ab4160597bf0bc3

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=725b9a93a191a6f82be2ea7d18a22850b8986476&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=retry
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=138425166&repo=autoland
> REFTEST TEST-UNEXPECTED-FAIL | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/foreignObject-img.html == file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/foreignObject-img-ref.html | image comparison, max difference: 255, number of differing pixels: 10000

Comment 10

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c44419e355549af0e2ff84ab9b9967bdcb13f14&selectedJob=138790072

Comment 11

[Cameron McCormack (:heycam)]

Comment on attachment 8920074 [details]
Bug 1409992 - Allow SVG as images to load data: URL images.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191076/diff/1-2/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce667ebd9b12
Allow SVG as images to load data: URL images. r=edgar

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ce667ebd9b12