1410006 - ESLint should automatically ignore all crashtest directories

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement, P2)

Description

[Mark Banner (:standard8)]

All of our crash tests are a specially crafted code that originally crashed Firefox.

We shouldn't lint them, as fixing the issues might invalidate the original test case.

We're not linting any crashtest directories at the moment, but I'm hoping we're going to be enabling some areas that contain crashtests very soon.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1410006 - ESLint should automatically ignore all crashtest directories; and clean up .eslintignore a bit.

Review commit: https://reviewboard.mozilla.org/r/191058/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191058/

Comment 2

[Dave Townsend [:mossop] (PTO until Aug 21st)]

Comment on attachment 8920061 [details]
Bug 1410006 - ESLint should automatically ignore all crashtest directories; and clean up .eslintignore a bit.

https://reviewboard.mozilla.org/r/191058/#review196460

::: .eslintignore:49
(Diff revision 1)
>  nsprpub/**
>  other-licenses/**
>  probes/**
>  startupcache/**
>  xpfe/**
> +# These directories only contain crashtests, but we still skip the whole

Add a newline above here.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8920061 [details]
Bug 1410006 - ESLint should automatically ignore all crashtest directories; and clean up .eslintignore a bit.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191058/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39444cb663f7
ESLint should automatically ignore all crashtest directories; and clean up .eslintignore a bit. r=mossop

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/39444cb663f7