1410021 - Send necessary update pings from the update agent

Status: RESOLVED FIXED

(Toolkit :: Application Update, enhancement, P3)

Description

[Georg Fritzsche [:gfritzsche]]

We added an update ping that allows tracking update staging and roll-out.
With the update agent, the signal for update staging would not be sent anymore from Firefox.

This bug is about sending it from the update agent instead.

Documentation for the ping is here: https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/data/update-ping.html

Some context is in chuttens article about the update signals: https://chuttenblog.wordpress.com/2017/10/04/anatomy-of-a-firefox-update/

Comment 1

[Georg Fritzsche [:gfritzsche]]

One interesting bit here: We should only send this ping when Telemetry upload is enabled.

This is controlled by the pref "datareporting.healthreport.uploadEnabled".
Changes at runtime should be respected.

Comment 2

[David Durst [:ddurst]]

Just one clarification: we need to account for update ping with reason ready, as that *might* need to be sent by the agent.

But that's only for the scenario wherein the session has ended and the update download finishes (read: becomes ready) when Firefox is not open; I believe all other scenarios would behave as they do now (with regard to Firefox sending the update ping).

Comment 3

[David Durst [:ddurst]]

(and we've moved this to 59)

Comment 4

[David Durst [:ddurst]]

We've changed our approach for the Update Agent -- rather than land incrementally in phases, we're going to go for the whole thing. This would require that all update pings would need to be sent from the Agent (if the Agent is in use -- they would remain sent from Firefox if the Agent is not in use).

Summary changed to reflect the scope adjustment.

Comment 5

[Nick Alexander :nalexander [he/him]]

The background update task sends Glean pings.