1410085 - Bookmarks query getRecentBookmarks in highlights doesn't return non-local bookmarks

Status: VERIFIED FIXED

(Firefox for iOS :: Data Storage, defect, P1)

Description

[Farhan Patel [:farhan]]

Due to changes in bookmarks sync as soon as a bookmark is uploaded it ceases to be local. 

The "getRecentBookmarks" query only looks at local bookmarks so if a user has sync enabled bookmarks never show up in highlights.

Comment 1

[Richard Newman [:rnewman]]

This is probably as simple as switching `ViewBookmarksLocalOnMirror` to `ViewAllBookmarks`.

It's probably worth guarding the change in this bug behind `MOZ_SIMPLE_BOOKMARKS_SYNCING` or (better) the same check that we use in `BookmarksModel` -- `hasOnlyUnmergedRemoteBookmarks` -- in order to behave correctly with merge deletions and partial uploads.

Comment 2

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request

Comment 3

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8921621 [details] [review]
GitHub Pull Request

Carrying over R+ from GitHub.

Comment 4

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/d0d126c5bbf89a6cca51129b3f164dbc520ad01d

Landed on v10.x:

https://github.com/mozilla-mobile/firefox-ios/commit/373e9141a7df675226ee2ebebaaf1df65f83c770

Comment 5

[Simon Basca [:SimonB]]

Verifying as fix on master 73081c03882 and beta 10.0(7473). Synced bookmarks are now displayed in Activity Stream Highlights.

Comment 6

[Justin D'Arcangelo [:justindarc]]

Attachment: Follow-up GitHub Pull Request

Posting :rnewman's follow-up PR here. Needs uplifted to v10.x.

Comment 7

[Justin D'Arcangelo [:justindarc]]

Landed follow-up on master:

https://github.com/mozilla-mobile/firefox-ios/commit/cab33d2fb711f2c88e852e552fe9cd901d4ebc7e

Landed follow-up on v10.x:

https://github.com/mozilla-mobile/firefox-ios/commit/2e2f0e6cd7b3635c97cc8314b11b20596167003b