Closed
Bug 1410086
Opened 6 years ago
Closed 6 years ago
avoid unnecessary refcounting in LabeledEventQueue::HasReadyEvent
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.41 KB,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
We can do better than what we are currently doing.
![]() |
Assignee | |
Comment 1•6 years ago
|
||
There's no need to copy events in the queue to check whether they are ready to run or not.
Attachment #8920159 -
Flags: review?(erahm)
Updated•6 years ago
|
Attachment #8920159 -
Flags: review?(erahm) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/dae2d770affc don't copy QueueEntry(ies) when checking LabeledEventQueue for ready events; r=erahm
![]() |
||
Comment 3•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/dae2d770affc
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•