avoid unnecessary refcounting in LabeledEventQueue::GetEvent

RESOLVED FIXED in Firefox 58

Status

()

Core
XPCOM
RESOLVED FIXED
a month ago
a month ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

(Blocks: 1 bug)

Trunk
mozilla58
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(1 attachment)

We can do a better job of refcounting here.
Created attachment 8920158 [details] [diff] [review]
don't copy QueueEntry(ies) when calling LabeledEventQueue::GetEvent

We were extracting elements from the queue and unnecessarily refcounting
them, rather than transferring the owning reference out of the queue and
out to the caller.
Attachment #8920158 - Flags: review?(erahm)
Attachment #8920158 - Flags: review?(erahm) → review+

Comment 2

a month ago
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/568b77a84f25
don't copy QueueEntry(ies) when calling LabeledEventQueue::GetEvent; r=erahm
https://hg.mozilla.org/mozilla-central/rev/568b77a84f25
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.