Closed Bug 1410095 Opened 3 years ago Closed 3 years ago
Prisjakt search engine does not work
59 bytes, text/x-review-board-request
bug 1408654 was about iOS. This is also broke on desktop and Android.
Searchplugins are available for testing here (they're modified with a different shortName, so you can recognize them, and have them both installed at the same time) https://l10n.mozilla-community.org/~flod/testsp/ Note that it's slightly different from the one that landed in iOS: as far as I know, rel=searchform is not something we use on mobile.
(In reply to Francesco Lodolo [:flod] from comment #1) > Note that it's slightly different from the one that landed in iOS: as far as > I know, rel=searchform is not something we use on mobile. Also: suggestions are http, search is https.
Attachment #8920194 - Flags: review?(mozilla) → review+
Comment on attachment 8920194 [details] Bug 1410095 - Fix search URLs in prisjakt.nu searchplugin for Swedish https://reviewboard.mozilla.org/r/191218/#review197338
(In reply to Mike Kaply [:mkaply] from comment #5) > Should we do a Param for the search? Yep, good call. (tried to comment via MozReview but somehow failed)
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/f9b62ceada2a Fix search URLs in prisjakt.nu searchplugin for Swedish r=mkaply
Comment on attachment 8920194 [details] Bug 1410095 - Fix search URLs in prisjakt.nu searchplugin for Swedish Approval Request Comment [Feature/Bug causing the regression]: - [User impact if declined]: searchplugin currently shipping doesn't work [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: yes [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: - [Is the change risky?]: no [Why is the change risky/not risky?]: only affecting a secondary searchplugin for one language (sv-SE) [String changes made/needed]: -
Attachment #8920194 - Flags: approval-mozilla-beta?
Comment on attachment 8920194 [details] Bug 1410095 - Fix search URLs in prisjakt.nu searchplugin for Swedish Must fix, Beta57+
Attachment #8920194 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.