1410095 - Prisjakt search engine does not work

Status: RESOLVED FIXED

(Firefox :: Search, defect, P1)

Description

[Mike Kaply [:mkaply]]

bug 1408654 was about iOS.

This is also broke on desktop and Android.

Comment 1

[Francesco Lodolo [:flod]]

Searchplugins are available for testing here (they're modified with a different shortName, so you can recognize them, and have them both installed at the same time)
https://l10n.mozilla-community.org/~flod/testsp/

Note that it's slightly different from the one that landed in iOS: as far as I know, rel=searchform is not something we use on mobile.

Comment 2

[Francesco Lodolo [:flod]]

Attachment: Bug 1410095 - Fix search URLs in prisjakt.nu searchplugin for Swedish

Review commit: https://reviewboard.mozilla.org/r/191218/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191218/

Comment 3

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #1)
> Note that it's slightly different from the one that landed in iOS: as far as
> I know, rel=searchform is not something we use on mobile.

Also: suggestions are http, search is https.

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 8920194 [details]
Bug 1410095 - Fix search URLs in prisjakt.nu searchplugin for Swedish

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191218/diff/1-2/

Comment 5

[Mike Kaply [:mkaply]]

Comment on attachment 8920194 [details]
Bug 1410095 - Fix search URLs in prisjakt.nu searchplugin for Swedish

https://reviewboard.mozilla.org/r/191218/#review196384

::: browser/locales/searchplugins/prisjakt-sv-SE.xml:11
(Diff revision 2)
>  <ShortName>Prisjakt</ShortName>
>  <Description>Prisjakt - jämför priser och produkter</Description>
>  <InputEncoding>UTF-8</InputEncoding>
>  <Image width="16" height="16">data:image/x-icon;base64,AAABAAEAEBAQAAAAAABoBQAAFgAAACgAAAAQAAAAIAAAAAEACAAAAAAAQAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAKieMACommAAqJaMAKyauAC0prwBMSLsAZF%2FFAH16zQBwa9EAi4nTALu55QCxrvYA7Ov4AP%2F%2F%2FwBwADIAaQBjAG8AAADAHiQAfO8SAEwAAAAoJYAAjAAAAOS%2F9QBxGuYAjAAAAJgFAgAA8BIAGAAAAHDvEgDI7xIA4xq%2BAIwAAACYBQIAAPASABgAAAAAAAAA2T7GABg%2FxgDkCQUAVAAAAGDyEgChUcYA5AkFAFQAAABg8hIAAAAAAMzyEgBghgcAHjvnAPc65wDg8hIAWAcXAKzvEgCw7xIAgP4SAAlI6QBYMOgA%2F%2F%2F%2FAB475wAbrQEAYIYHAODyEgBYBxcABACkAAAApAD%2F%2F%2F8AsAgAAAAAQAAEAKQAZAAAAGIAbQBwADIAaQBjAG8ALgBlAHgAZQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAHQAAAAAAAAAAAAAAAAAAAACAAAAXPESALgLpADoC8IAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA6AvCAAAAAAAAAAAAAAAAAP%2F%2F%2FwAAAAAAAAAAAAAAAAAAAAAAX6bnAAAAAAAAAAAAAAAAAAAAAAAoLxQAAAAAAAkOAgACDgIADQAAAADw%2FQAA4P0AAg4CAAkOAgAAAAAA9gvCAODyEgBSAAAAAAAAACTVpAAAAAAA%2F%2F%2F%2FAFzxEgBq8RIAXPESAMzx5wAEwPUARPESAAAAFACoRPkARQAAAHgTFAAAABQAoCAUABzxEgAg8RIAZPMSAPCI%2BgBSAAAAAAAAAJDWpAAAAAAAOor1AAAAAAAA7P0AAAAAAAAAAABwADIAaQBjAG8AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACDO8YApTbGAM0JAQAPAIUAAAAAAJDWpADNCQEAAQAAAAAAAAAAAAAAFTbGAM0JAQAAAAEAwU1BAM0JAQAAAwAABMD1AFik5wB0AAAAAAAAAOjyEgB0AAAAAAAAAAAAAAD%2F%2F%2F8AAAAAAAAAAAAAAAAAAAAAAP%2F%2F%2FwAAAAAAAAAAAAAAAAAAAAAAKC8UAAAAAABkxfUAqfHnAIwAAAAAAAAAAAAAAAAAAAB88hIAAADdAAADAAAAAAAAyfHnAAADAAAAAN0AjAAAAAAAAAAAAwAAAQAYAAAAAABw8hIAAAAAAKqb9QCzm%2FUA4PUSACQAAgAA7P0AEW5AAAUAAAAkAAIAAPD9AJzyEgACAAAAQKP1AJACAgD5m%2FUA4En8ACOj9QAro%2FUAAAAAAAgCAACgIBQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAVAAAAAAAAAAAAAAAACwgGFQYICwAAAAAAAAANCgUEBAEEBAUKDQAAAAAACgQEBwwCBAQEBAoAAAAACwUEBAQOAwQEBAQFCwAAAAgEBAwODg4OCQQEBAgAAAAGBAQEBAQEBA4EBAQGAAAVFQECAwwODg4MAwIBFRUAAAYEBAQOBAMEBAQEBAYAAAAIBAQECQ4ODg4MBAQIAAAACwUEBAQEAw4EBAQFCwAAAAAKBAQEBAIMBwQECgAAAAAADQoFBAQBBAQFCg0AAAAAAAAACwgGFQYICwAAAAAAAAAAAAAAABUAAAAAAAAAAP%2F%2FRgD%2B%2FwAA8B8AAMAHAADABwAAgAMAFYADAACAAwAAAAEAAIADBhWAAwsAgAMAAMAHDQrABwQB8B8FCv7%2FAAA%3D</Image>
> -<Url type="text/html" method="GET" template="http://www.prisjakt.nu/supersearch.php" resultdomain="prisjakt.nu">
> -  <Param name="s" value="{searchTerms}"/>
> +<Url type="text/html" method="GET" template="https://www.prisjakt.nu/#rparams=ss={searchTerms}" resultdomain="prisjakt.nu" rel="searchform"/>
> +<Url type="application/x-suggestions+json" method="GET" template="https://www.prisjakt.nu/plugins/opensearch/suggestions.php?search={searchTerms}"/>

Should we do a Param for the search?

Comment 6

[Francesco Lodolo [:flod]]

Comment on attachment 8920194 [details]
Bug 1410095 - Fix search URLs in prisjakt.nu searchplugin for Swedish

https://reviewboard.mozilla.org/r/191218/#review197338

Comment 7

[Francesco Lodolo [:flod]]

Comment on attachment 8920194 [details]
Bug 1410095 - Fix search URLs in prisjakt.nu searchplugin for Swedish

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191218/diff/2-3/

Comment 8

[Francesco Lodolo [:flod]]

(In reply to Mike Kaply [:mkaply] from comment #5)
> Should we do a Param for the search?

Yep, good call.
(tried to comment via MozReview but somehow failed)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9b62ceada2a
Fix search URLs in prisjakt.nu searchplugin for Swedish r=mkaply

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f9b62ceada2a

Comment 11

[Francesco Lodolo [:flod]]

Comment on attachment 8920194 [details]
Bug 1410095 - Fix search URLs in prisjakt.nu searchplugin for Swedish

Approval Request Comment
[Feature/Bug causing the regression]: -

[User impact if declined]: searchplugin currently shipping doesn't work

[Is this code covered by automated tests?]: no

[Has the fix been verified in Nightly?]: yes

[Needs manual test from QE? If yes, steps to reproduce]:  no

[List of other uplifts needed for the feature/fix]: -

[Is the change risky?]: no

[Why is the change risky/not risky?]: only affecting a secondary searchplugin for one language (sv-SE)

[String changes made/needed]: -

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8920194 [details]
Bug 1410095 - Fix search URLs in prisjakt.nu searchplugin for Swedish

Must fix, Beta57+

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1d09f3b353c7