Closed Bug 1410096 Opened 2 years ago Closed 2 years ago

LabeledEventQueue::PutEvent is slow

Categories

(Core :: XPCOM, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: smaug, Assigned: farre)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

When profiling https://bugzilla.mozilla.org/show_bug.cgi?id=1254240#c0, LabeledEventQueue::PutEvent is over 11% of the postMessage() call time in worker.
Of that 1/3 is hashtable operations.
Malloc is over 20% (looks like we push stuff to a Queue).
Then there is some extra addref/release and QI.
Assignee: nobody → afarre
There aren't any available xpcom reviewers as far as I can tell. I ran this through the profiler and it fixes the perf issues as far as I can tell.
Attachment #8932084 - Flags: feedback?(wmccloskey)
Attachment #8932084 - Flags: feedback?(wmccloskey) → review?(bugs)
Attachment #8932084 - Flags: review?(bugs) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4418485f0512
Move labeled queues to SchedulerGroup. r=smaug
Keywords: checkin-needed
Backed out for bustage at dist/include/mozilla/SchedulerGroup.h:186:

https://hg.mozilla.org/integration/mozilla-inbound/rev/d1b45fb8d2049dd04d169582e099a34140abfdfe

Push with bustage: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=4418485f0512638f30cc43c62c16dd97ba1f2c69&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=retry
Build log: https://treeherder.mozilla.org/logviewer.html#?job_id=149594847&repo=mozilla-inbound

 /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/SchedulerGroup.h:186:23: error: expected ';' at end of member declaration
/builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/SchedulerGroup.h:186:46: error: expected ')' before 'aPriority'
/builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/SchedulerGroup.h:226:42: error: 'EventPriority' was not declared in this scope
Flags: needinfo?(afarre)
Add missing header to fix build bustage. Carrying over r+
Attachment #8932084 - Attachment is obsolete: true
Flags: needinfo?(afarre)
Attachment #8935343 - Flags: review+
Make unified build work for dom/plugins. EventPriority from AbstractEventQueue.h clashes with mac headers.
Attachment #8935344 - Flags: review?(jmathies)
Comment on attachment 8935344 [details] [diff] [review]
0002-Bug-1410096-Make-unified-build-work.-r-jimm.patch

Smaug, can you review this?
Attachment #8935344 - Flags: review?(jmathies) → review?(bugs)
Comment on attachment 8935344 [details] [diff] [review]
0002-Bug-1410096-Make-unified-build-work.-r-jimm.patch

rs+
Attachment #8935344 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/0b8cec51ffc2
https://hg.mozilla.org/mozilla-central/rev/51e4d95d19a4
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.