Closed Bug 1410145 Opened 7 years ago Closed 7 years ago

Android sync ping has wrong document version.

Categories

(Firefox for Android Graveyard :: Android Sync, enhancement)

enhancement
Not set
normal

Tracking

(firefox58 fixed)

RESOLVED FIXED
Firefox 58
Tracking Status
firefox58 --- fixed

People

(Reporter: tcsc, Assigned: tcsc)

References

Details

Attachments

(1 file)

This is unfortunate, but is a trivial fix to make.
For future reference, it currently says 5, but the version described here is 4. https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/data/common-ping.html
So what's the plan with getting v5 pings processed?
Added relevant see also. Once that lands I'll try and get a backfill scheduled.
See Also: → 1410152
At the very least, the v4->v5 change is consistent with the misplacement of 'os' (Bug 1409860). That is, bundle contents changed, and so version was bumped.

Similarly, any reason we didn't bump the payload version when 'os' stuff was added?
Flags: needinfo?(tchiovoloni)
See Also: → 1409860
Comment on attachment 8920268 [details]
Bug 1410145 - Fix wrong version field in android sync ping.

https://reviewboard.mozilla.org/r/191292/#review196458
Attachment #8920268 - Flags: review?(gkruglov) → review+
Because it was a backwards-compatible change -- we added an optional field. Historically we haven't ever bumped the payload version because there hasn't really been a need to. We ignore it, mostly because we don't really enforce strict schema compliance, due to none of the clients other than desktop following it, it's more of a "best effort" thing, unfortunately.

We probably should have bumped it when with issues like single-sync pings to multi-sync pings.

Anyway, I opened bug 1410161 earlier today which would allow us to move towards actually enforcing a schema.
Flags: needinfo?(tchiovoloni)
Pushed by tchiovoloni@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5934eecb4afc
Fix wrong version field in android sync ping. r=Grisha
https://hg.mozilla.org/mozilla-central/rev/5934eecb4afc
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: