Closed Bug 1410159 Opened 2 years ago Closed 2 years ago

Add more methods to HandlerProvider::GetEffectiveOutParamIid

Categories

(Core :: Disability Access APIs, enhancement)

Unspecified
Windows
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

(Depends on 1 open bug)

Details

(Whiteboard: aes+)

Attachments

(1 file)

From bug 1406822 comment 9:

> this should be extended to cover some other interfaces/methods:
> IAccessible2_2::accessibleWithCaret
> IAccessibleDocument::anchorTarget
> IAccessibleRelation::target (singular; targets is covered by the array data
> stuff)
> IAccessibleTableCell::table
> All of these could be treated as IAccessible2_3, although someone might call
> IAccessibleTableCell::table and then query to IAccessibleTable2 instead.
> Still, that can be dealt with separately.
> IAccessible2_3::selectionRanges also has two IUnknown* within its IA2Range
> struct out param. Does ICallFrame::WalkFrame handle interface pointers in
> structs already?
Whiteboard: aes+
(In reply to Aaron Klotz [:aklotz] (a11y work receiving priority right now, please send interceptor reviews to dmajor or handyman) from comment #0)
> From bug 1406822 comment 9:
> 
> > IAccessible2_3::selectionRanges also has two IUnknown* within its IA2Range
> > struct out param. Does ICallFrame::WalkFrame handle interface pointers in
> > structs already?

This one I am unsure about. We'll have to test this first, methinks.
I'm moving the selectionRanges part to bug 1414074.
Attached patch Add more entriesSplinter Review
This adds all of the aforementioned entries except for IAccessible2_3::selectionRanges, which I have moved to a new bug.
Assignee: nobody → aklotz
Status: NEW → ASSIGNED
Attachment #8924755 - Flags: review?(jteh)
Comment on attachment 8924755 [details] [diff] [review]
Add more entries

Great. Thanks!
Attachment #8924755 - Flags: review?(jteh) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/e255f93c08085eb8a4034d320c6af48827619908
Bug 1410159: Add additional IUnknown resolution to a11y::HandlerProvider; r=Jamie
https://hg.mozilla.org/mozilla-central/rev/e255f93c0808
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Depends on: 1418991
You need to log in before you can comment on or make changes to this bug.