Closed Bug 1410185 Opened 8 years ago Closed 8 years ago

Browser action sheet not respecting safe area for iPhone X

Categories

(Firefox for iOS :: Browser, defect, P1)

Product:
Firefox for iOS
Component:
Browser
Platform:
Other
iOS
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
fxios 10.0 ---
fxios-v11.0 --- verified

People

(Reporter: bunn, Unassigned)

Details

Attachments

(2 files)

bottombar_action_before.png
436.87 KB, image/png
Details
Pull request
55 bytes, text/x-github-pull-request
bunn
: review?
Details | Review
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:56.0) Gecko/20100101 Firefox/56.0 Build ID: 20170926190823 Steps to reproduce: Open current master on iPhone X simulator. Tap on the bottom right icon to open the action sheet Actual results: The action sheet opens but overlaps with rounded device corners and home indicator Expected results: App should use safe area into consideration to layout the action sheet
Attached file Pull request —
Attachment #8920299 - Flags: review?
Attachment #8920294 - Attachment description: bottombar_action_after_before.png → bottombar_action_before.png
Attachment #8920294 - Attachment filename: bottombar_action_after_before.png → bottombar_action_before.png
tracking-fxios: --- → 10.0
Priority: -- → P1
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Verifying as fix on master 754cdb106707.
Status: RESOLVED → VERIFIED
status-fxios-v11.0: --- → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: