Closed
Bug 1410255
Opened 7 years ago
Closed 6 years ago
Centralize logic for detecting try builds in taskgraph generation.
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla59
People
(Reporter: tomprince, Assigned: tomprince)
Details
Attachments
(2 files, 1 obsolete file)
In https://bugzilla.mozilla.org/show_bug.cgi?id=1410137#c2, :dustin suggested > I think this is OK as-is, but I suspect there are still places looking for > either project == 'try' or level == 1. It'd be nice to centralize this > logic into an `is_try` parameter. Good followup fodder?
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → mozilla
Comment 1•6 years ago
|
||
Comment on attachment 8942942 [details] Bug 1410255: Factor out determination of `try` to helper function; r?dustin Dustin J. Mitchell [:dustin] has approved the revision. https://phabricator.services.mozilla.com/D398#9594
Attachment #8942942 -
Flags: review+
Pushed by mozilla@hocat.ca: https://hg.mozilla.org/integration/mozilla-inbound/rev/2155b487e8ad Factor out determination of `try` to helper function; r=dustin
Comment 3•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2155b487e8ad
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Updated•6 years ago
|
Product: TaskCluster → Firefox Build System
Comment 4•6 years ago
|
||
Comment on attachment 8943436 [details] Bug 1410255: Use `is_try` in more places; r?dustin Dustin J. Mitchell [:dustin] pronoun: he has approved the revision. https://phabricator.services.mozilla.com/D411
Attachment #8943436 -
Flags: review+
Comment 5•6 years ago
|
||
Updated•6 years ago
|
Attachment #8967781 -
Attachment is obsolete: true
Pushed by mozilla@hocat.ca: https://hg.mozilla.org/integration/mozilla-inbound/rev/f7c788901aa1 Use `is_try` in more places; r=dustin
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f7c788901aa1
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f7c788901aa1
You need to log in
before you can comment on or make changes to this bug.
Description
•