1410255 - Centralize logic for detecting try builds in taskgraph generation.

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Tom Prince [:tomprince]]

In https://bugzilla.mozilla.org/show_bug.cgi?id=1410137#c2, :dustin suggested 

> I think this is OK as-is, but I suspect there are still places looking for
> either project == 'try' or level == 1.  It'd be nice to centralize this
> logic into an `is_try` parameter.  Good followup fodder?

Comment 1

[Phabricator Automation]

Comment on attachment 8942942 [details]
Bug 1410255: Factor out determination of `try` to helper function; r?dustin

Dustin J. Mitchell [:dustin] has approved the revision.

https://phabricator.services.mozilla.com/D398#9594

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2155b487e8ad
Factor out determination of `try` to helper function; r=dustin

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2155b487e8ad

Comment 4

[Phabricator Automation]

Comment on attachment 8943436 [details]
Bug 1410255: Use `is_try` in more places; r?dustin

Dustin J. Mitchell [:dustin] pronoun: he has approved the revision.

https://phabricator.services.mozilla.com/D411

Comment 5

[Phabricator Automation]

Attachment: Bug 1410255: Use `is_try` in more places; r?dustin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7c788901aa1
Use `is_try` in more places; r=dustin

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f7c788901aa1

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f7c788901aa1