1410338 - [Photon] Incorrect color for History Panel message

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P1)

Description

[Sorina Florean [:sflorean]]

Attachment: Screenshot_20171020-112834.png

Environment: 
Device: Samsung Galaxy Tab 3 (Android 7.0);
Build: Nightly 58.0a1 (2017-10-17);

Steps to reproduce:
1. Launch fennec with a clean profile;
2. Go to History panel;

Expected result:
"Psst: using a New Private Tab won't save your history" has blue (photon) color.

Actual result:
 "Psst: using a New Private Tab won't save your history" has orange color.

Comment 1

[Wesly Huang (EPM)]

Carol, would you help check it? tks.

Comment 2

[Nevin Chen(Not active on Bugzilla)]

I don't think we have spec for it. I'll let Carol decide the color.

Comment 3

[Carol Huang [:Carol]]

Please change the orange to #0a84ff color. thanks!

Comment 4

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1410338 - Incorrect color for History Panel message.

Review commit: https://reviewboard.mozilla.org/r/191880/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191880/

Comment 5

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8920936 [details]
Bug 1410338 - Incorrect color for History Panel message.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191880/diff/1-2/

Comment 6

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8920936 [details]
Bug 1410338 - Incorrect color for History Panel message.

https://reviewboard.mozilla.org/r/191880/#review197072

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e992675a27d
Incorrect color for History Panel message. r=nechen

Comment 8

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8920936 [details]
Bug 1410338 - Incorrect color for History Panel message.

Approval Request Comment
[Feature/Bug causing the regression]: Align new photon design
[User impact if declined]: User will see old color
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]:no
[Needs manual test from QE? If yes, steps to reproduce]:  no
[List of other uplifts needed for the feature/fix]:no
[Is the change risky?]:no
[Why is the change risky/not risky?]: just change color
[String changes made/needed]:no

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5e992675a27d

Comment 10

[Oana Horvath [:ohorvath]]

Verified as fixed on Nightly 58 (2017-24-10).
Devices:
Xiaomi Mi Pad 2 (Android 5.1)
Samsung Galaxy Tab 3 (Android 7.0)

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8920936 [details]
Bug 1410338 - Incorrect color for History Panel message.

Low risk fix for a very visible recent regression, Beta57+

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1b1c2b18e426

Comment 13

[u549602]

Verified as fixed on the 57.0 RC build
This issue was tested on a Pixel C (Android 8.0) device