1410403 - WebCrypto: incorrect oid for ecdsa keys in spki

Status: RESOLVED FIXED

(Core :: DOM: Web Crypto, defect, P3)

Description

[ondra zara]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20171003100843

Steps to reproduce:

ECDSA keys exported via WebExpo to spki shall have the algo OID of "1.2.840.10045.2.1" as per https://www.w3.org/TR/WebCryptoAPI/#ecdsa-operations.

Currently, these keys have OID "1.3.132.112".


Actual results:

The OID is "1.3.132.112"


Expected results:

The OID shall be "1.2.840.10045.2.1".

Comment 1

[ondra zara]

Typo: s/WebExpo/WebCrypto/

Comment 2

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

The ecdh OID is also wrong as per https://github.com/w3c/webcrypto/issues/86

Comment 4

[Christoph Kerschbaumer [:ckerschb]]

JC, P2 in Dom:Security requires someone to be assigned to it. Can you help me find either an assignee or alternatively we could change the priority. What do you think?

Comment 5

[J.C. Jones [:jcj] (he/him) [increased latency due to COVID-19]]

Eventually I expect it will be Dana or me, but let's put it at P3 for now.

Comment 6

[kll]

Note that while this bug may appear inconsequential, it actually prevents easily importing the key into other contexts like OpenSSL. The ASN has to be manually opened and fixed.

Comment 7

[J.C. Jones [:jcj] (he/him) [increased latency due to COVID-19]]

Thanks for the heads-up, kll, that's useful to know. With the updates from Bug 1564509 this is straightforward. I'll post a patch shortly.

Comment 8

[J.C. Jones [:jcj] (he/him) [increased latency due to COVID-19]]

Attachment: Bug 1410403 - Use id-ecPublicKey for ECDH key export from WebCrypto r?keeler

id-ecPublicKey is defined as the OID {iso(1) member-body(2) us(840)
ansi-x962(10045) keyType(2) ecPublicKey(1)}, and is the NSS default, so
remove the override code from CryptoKey.cpp that forced it to the legacy
id-ecDH code.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35f2efaaeff6
Use id-ecPublicKey for ECDH key export from WebCrypto r=keeler

Comment 10

[J.C. Jones [:jcj] (he/him) [increased latency due to COVID-19]]

Attachment: Bug 1410403 - Fixup, mark as fixed relevant WebCrypto Web Platform Tests CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&classifiedState=unclassified&searchStr=android%2C7.0%2Cx86-64%2Cdebug%2Cweb%2Cplatform%2Ctests%2Ctest-android-em-7.0-x86_64%2Fdebug-geckoview-web-platform-tests-e10s-2%2Cw%28wpt2%29&fromchange=72df434c8422366872d4050e9d9ba3e3121a4fbe&selectedJob=276033065

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4ef4d6cdff0
Fixup, mark as fixed relevant WebCrypto Web Platform Tests UPGRADE_NSS_RELEASE CLOSED TREE

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/35f2efaaeff6
https://hg.mozilla.org/mozilla-central/rev/a4ef4d6cdff0