1410522 - Re-enable download protection in non-official builds

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, enhancement, P2)

Description

[François Marier [:francois]]

The download protection lists should now be available to non-official Firefox builds too.

This means we could revert the changes from bug 1394053.

Comment 1

[François Marier [:francois]]

Attachment: Bug 1410522 - Enable download protection on non-official builds too.

This reverts the change introduced in bug 1394053.

Google has made the download protection lists available to everyone
and so we no longer need to restrict the download protection feature
to official builds.

Review commit: https://reviewboard.mozilla.org/r/216462/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216462/

Comment 2

[Johann Hofmann [:johannh]]

Comment on attachment 8946496 [details]
Bug 1410522 - Enable download protection on non-official builds too.

https://reviewboard.mozilla.org/r/216462/#review222312

Thanks!

Comment 3

[Johann Hofmann [:johannh]]

Note that https://hg.mozilla.org/mozilla-central/rev/05907bcce126 introduced some if-conditions that could theoretically be cleaned up, too, but I don't want to block review on it. You could either amend your commit or make a good first bug?

Comment 4

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8946496 [details]
Bug 1410522 - Enable download protection on non-official builds too.

https://reviewboard.mozilla.org/r/216462/#review222330

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/478aba1b67a4
Enable download protection on non-official builds too. r=gcp,johannh

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/478aba1b67a4