1410540 - Remove the 'viewbutton' XBL binding and pageInfo.xml

Status: RESOLVED FIXED

(Firefox :: Page Info Window, task)

Description

[Brian Grinstead [:bgrins]]

The viewbutton binding seems to be a way to control the display of the radiogroup radio headers in the page info window (i.e. "General", "Media", "Security", etc).

We used to support extensions injecting new headers through an overlay (https://dxr.mozilla.org/mozilla-central/source/browser/base/content/pageinfo/pageInfo.xul#84). Since that's not needed anymore, I'm assuming we can remove the XBL binding and modify the markup as needed in the radiogroup to keep things looking the same.

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1410540 - Remove the 'viewbutton' XBL binding and pageInfo.xml;

Review commit: https://reviewboard.mozilla.org/r/191706/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191706/

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: Bug 1410540 - Merge viewbutton.css into pageInfo.css for osx;

Page Info is the only place viewbutton.css is referenced

Review commit: https://reviewboard.mozilla.org/r/192170/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192170/

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8920708 [details]
Bug 1410540 - Remove the 'viewbutton' XBL binding and pageInfo.xml;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191706/diff/1-2/

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8920708 [details]
Bug 1410540 - Remove the 'viewbutton' XBL binding and pageInfo.xml;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191706/diff/2-3/

Comment 5

[Brian Grinstead [:bgrins]]

Comment on attachment 8921182 [details]
Bug 1410540 - Merge viewbutton.css into pageInfo.css for osx;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/192170/diff/1-2/

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8920708 [details]
Bug 1410540 - Remove the 'viewbutton' XBL binding and pageInfo.xml;

https://reviewboard.mozilla.org/r/191706/#review198060

::: commit-message-d1e99:4
(Diff revision 3)
> +Bug 1410540 - Remove the 'viewbutton' XBL binding and pageInfo.xml;r=dao
> +
> +Instead of creating a new binding that extends the radio binding to remove the actual
> +radio input from the DOM, with this change we use the platform-specific radio bindings

Hmm, we should get rid of the platform-specific bindings, which should simplify this patch. I did that for <checkbox/> in bug 1345432. Mind doing the same here?

Comment 7

[Brian Grinstead [:bgrins]]

(In reply to Dão Gottwald [::dao] from comment #6)
> Comment on attachment 8920708 [details]
> Bug 1410540 - Remove the 'viewbutton' XBL binding and pageInfo.xml;
> 
> https://reviewboard.mozilla.org/r/191706/#review198060
> 
> ::: commit-message-d1e99:4
> (Diff revision 3)
> > +Bug 1410540 - Remove the 'viewbutton' XBL binding and pageInfo.xml;r=dao
> > +
> > +Instead of creating a new binding that extends the radio binding to remove the actual
> > +radio input from the DOM, with this change we use the platform-specific radio bindings
> 
> Hmm, we should get rid of the platform-specific bindings, which should
> simplify this patch. I did that for <checkbox/> in bug 1345432. Mind doing
> the same here?

That sounds like a good idea and should ultimately make migration to a Custom Element for radios easier - I filed Bug 1411640 for that

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 8921182 [details]
Bug 1410540 - Merge viewbutton.css into pageInfo.css for osx;

https://reviewboard.mozilla.org/r/192170/#review200412

not sure if this patch is still relevant on its own

Comment 9

[Brian Grinstead [:bgrins]]

(In reply to Dão Gottwald [::dao] from comment #8)
> not sure if this patch is still relevant on its own

It's not - this is blocked on Bug 1411640

Comment 10

[Brian Grinstead [:bgrins]]

Comment on attachment 8920708 [details]
Bug 1410540 - Remove the 'viewbutton' XBL binding and pageInfo.xml;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191706/diff/3-4/

Comment 11

[Brian Grinstead [:bgrins]]

Comment on attachment 8921182 [details]
Bug 1410540 - Merge viewbutton.css into pageInfo.css for osx;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/192170/diff/2-3/

Comment 12

[Brian Grinstead [:bgrins]]

Rebased and updated now that we have a unified radio binding after bug 1411640

Comment 13

[Dão Gottwald [:dao]]

Comment on attachment 8920708 [details]
Bug 1410540 - Remove the 'viewbutton' XBL binding and pageInfo.xml;

https://reviewboard.mozilla.org/r/191706/#review202848

::: commit-message-d1e99:4
(Diff revision 4)
> +Bug 1410540 - Remove the 'viewbutton' XBL binding and pageInfo.xml;r=dao
> +
> +Instead of creating a new binding that extends the radio binding to remove the actual
> +radio input from the DOM, with this change we use the platform-specific radio bindings

s/platform-specific radio bindings/default radio binding/

Comment 14

[Dão Gottwald [:dao]]

Comment on attachment 8921182 [details]
Bug 1410540 - Merge viewbutton.css into pageInfo.css for osx;

https://reviewboard.mozilla.org/r/192170/#review202850

Comment 15

[Brian Grinstead [:bgrins]]

Comment on attachment 8920708 [details]
Bug 1410540 - Remove the 'viewbutton' XBL binding and pageInfo.xml;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191706/diff/4-5/

Comment 16

[Brian Grinstead [:bgrins]]

Comment on attachment 8921182 [details]
Bug 1410540 - Merge viewbutton.css into pageInfo.css for osx;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/192170/diff/3-4/

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/765f81d5cd73
Remove the 'viewbutton' XBL binding and pageInfo.xml;r=dao
https://hg.mozilla.org/integration/autoland/rev/f1b40946cdbe
Merge viewbutton.css into pageInfo.css for osx;r=dao

Comment 18

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/765f81d5cd73
https://hg.mozilla.org/mozilla-central/rev/f1b40946cdbe