1410618 - [Form Autofill] Form autofill remains in English

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect)

Description

[Francesco Lodolo [:flod]]

Italian has been localized for a few days now, but localization is still not available

chrome://formautofill/locale/formautofill.properties shows only English strings. I guess something is wrong with the build configuration.

Comment 1

[Francesco Lodolo [:flod]]

locales/jar.mn looks quite different from the one in a similar extension (webcompat)

http://searchfox.org/mozilla-central/rev/bc6dddb88b1f34b54e22efc205846975fb4c04cb/browser/extensions/formautofill/locales/jar.mn

@AB_CD@.jar:
% locale formautofill @AB_CD@ %locale/@AB_CD@/
  locale/@AB_CD@/                (en-US/*)

http://searchfox.org/mozilla-central/rev/bc6dddb88b1f34b54e22efc205846975fb4c04cb/browser/extensions/webcompat-reporter/locales/jar.mn

[features/[e-mail]] @AB_CD@.jar:
% locale webcompat-reporter @AB_CD@ %locale/@AB_CD@/
  locale/@AB_CD@/webcompat.properties (%webcompat.properties)

Not sure if this is the only problem

Comment 2

[Luke Chang [:lchang] (inactive)]

Thanks for raising this.

Scott, Could you look into it? Thanks.

Comment 3

[Scott Wu [:scottwu]]

(In reply to Francesco Lodolo [:flod] from comment #1) 
> @AB_CD@.jar:
> % locale formautofill @AB_CD@ %locale/@AB_CD@/
>   locale/@AB_CD@/                (en-US/*)

Yes I suspect this is the cause. Do you know how I could test this locally?

Comment 4

[Scott Wu [:scottwu]]

Attachment: Bug 1410618 - Use the correct .properties file for Form Autofill

Review commit: https://reviewboard.mozilla.org/r/191926/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191926/

Comment 5

[Francesco Lodolo [:flod]]

See https://blog.mozilla.org/l10n/2017/08/04/create-a-localized-build-locally/ and  https://firefox-source-docs.mozilla.org/build/buildsystem/locales.html

Also :pike should be able to help reviewing this.

Comment 6

[Axel Hecht [:Pike]]

Right now, try l10n is failing, but that may be because it's the "wrong" try.

I triggered a couple of jobs on https://treeherder.mozilla.org/#/jobs?repo=try&revision=258ce47f945e&selectedJob=138889539 to see if we get better results.

PS: The kinds of l10n on try:
"L10n" symbol, repackaging the mozilla-central Nightlies with your current build logic.
The "L10n" group, N7 symbol: Building a "Nightly" off of your revision on try, repackaging that for a set of two locales.

Comment 7

[Axel Hecht [:Pike]]

Comment on attachment 8920959 [details]
Bug 1410618 - Use the correct .properties file for Form Autofill

https://reviewboard.mozilla.org/r/191926/#review197596

The new jobs on try are green, and I inspected the Italian language pack to contain the formautofill.properties.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a3a4af186ce
Use the correct .properties file for Form Autofill r=Pike

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6a3a4af186ce

Comment 10

[Francesco Lodolo [:flod]]

Verified, I have Italian translation in 58.0a1 (2017-10-25) (64 bit).