1410689 - [CID 1419987] Leak in GMPContentChild::RecvPChromiumCDMConstructor()

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

If err isn'g GMPNoErr, we'll leak a cdm structure.  I suggest moving the 'if' up to before 'new'.


** CID 1419987:  Resource leaks  (RESOURCE_LEAK)
/dom/media/gmp/GMPContentChild.cpp: 303 in mozilla::gmp::GMPContentChild::RecvPChromiumCDMConstructor(mozilla::gmp::PChromiumCDMChild *)()


________________________________________________________________________________________________________
*** CID 1419987:  Resource leaks  (RESOURCE_LEAK)
/dom/media/gmp/GMPContentChild.cpp: 303 in mozilla::gmp::GMPContentChild::RecvPChromiumCDMConstructor(mozilla::gmp::PChromiumCDMChild *)()
297         cdm =
298           new ChromiumCDM8BackwardsCompat(
299             host9,
300             static_cast<cdm::ContentDecryptionModule_8*>(cdm));
301         if (err != GMPNoErr) {
302           NS_WARNING("GMPGetAPI call failed trying to get CDM.");
>>>     CID 1419987:  Resource leaks  (RESOURCE_LEAK)
>>>     Variable "cdm" going out of scope leaks the storage it points to.
303           return IPC_FAIL_NO_REASON(this);
304         }
305       }
306     
307       child->Init(static_cast<cdm::ContentDecryptionModule_9*>(cdm));
308

Comment 1

[James Cheng[:JamesCheng]]

Thank you, I will fix it soon.

Comment 2

[James Cheng[:JamesCheng]]

Attachment: Bug 1410689 - Early return before creating ChromiumCDM8BackwardsCompat to avoid leak.

Review commit: https://reviewboard.mozilla.org/r/191872/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191872/

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8920932 [details]
Bug 1410689 - Early return before creating ChromiumCDM8BackwardsCompat to avoid leak.

https://reviewboard.mozilla.org/r/191872/#review197046

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d936c6da5ff3
Early return before creating ChromiumCDM8BackwardsCompat to avoid leak. r=gerald

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d936c6da5ff3