1410767 - Private Browsing tabs survive Firefox restart when using "Close all" apps on a Samsung S4

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Session Restore, defect, P5)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

STR:
1. Start Firefox beta (57)
2. Open some pages (page A and B) in pb mode
3. Long-press and "Close all" android apps
4. Start Firefox beta

Expected result:
- New tab (or whatever non-pb tab was open last); Zero pb tabs

Actual result:
- Page A appears; Two pb tabs: A and B

This appears to be a regression, as 56 does not have this problem.

Comment 1

[Jan Henning [:JanH]]

What device/OS version are you using?
Also, what happens if instead of "Close all" you swipe away just the entry for Firefox?

Unfortunately, I cannot reproduce this on either of my phones (Moto G4 Play, Android 6.0.1; S3 Mini, Android 4.1.2). 
Private tabs are preserved as designed if Firefox is merely OOM-killed (either for real, or simulated through adb shell am kill <package-name>), but
- quitting Firefox (if the corresponding menu option is enabled)
- swiping it away in the task switcher (neither phone has an inbuilt "Close all" button, though)
- force-stopping Firefox either via App Settings or ADB

all kill the private browsing session as expected.

So far some reason it seems like "Close all" on your device now only does something that equates to an OOM-kill and preserves the app's saved instance data. If as you say everything's still working fine on 56, I've no idea what might have caused a difference in behaviour here, though.
Since I cannot reproduce this myself, the results of a mozregression run by somebody who can would be most appreciated.

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

If I just swipe away the Firefox entry then it works. The problem only happens with "Close all", weird.

This is on a Samsung S4, Android 5.0.1

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

I've re-tested with 56 and now it happens there as well. Not sure what's going on. Maybe I side-swiped when I tested 56 earlier, as I may have had multiple Firefoxes running, don't remember.

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

In testing this, I also see odd behavior, filed as bug 1410934.

Comment 5

[Jan Henning [:JanH]]

Hmm, maybe somebody with an affected phone has a clever idea on how to differentiate whether we've been subject to "Clear all" or just a garden-variety OOM kill and then manually reset the savedInstanceState on affected phones in the former case?

Comment 6

[Nevin Chen(Not active on Bugzilla)]

Maybe we can have QA to help and see if we can reproduce this
f+ for now

Comment 7

[Wesly Huang (EPM)]

I wonder how common is it, seems like device specific?

Ioana, maybe you'll be able to help arrange a test with more devices? Thanks.

I think P3 is enough before that.

Comment 8

[Ioana Chiorean]

I've verified on several devices together with Bogdan. The "close all apps" is specific for Samsung flavor android.
We were not able to reproduce it on Tab S3 and S6 with any build from 57->59.

Jan-Ivar are you still able to reproduce it?

Comment 9

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Yes I can still reproduce on my android Samsung S4 (FF 57.0b11), and I still see bug 1410934 as well when I do, as mentioned in comment 4.

Do you have an S4 to test?

Comment 10

[naga_maga]

This probably won't help much, but i had maybe somewhat related problem on Samsung Galaxy J7 (2016), with Android 7.0 system. Several times i had Firefox restore private tabs after closing all of them (using close all private tabs option) and few hours of not using it, so there certainly is something fishy with private tabs being restored under some circumstances, even though in my opinion they should just be anihilated as soon as they are closed (and the "revert closing the tab" pop-up is gone).

Comment 11

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 12

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.