1410828 - Add automated test for "Hover and `Dismiss` Top Sites tile"

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P3)

Description

[Ioana Crisan]

testrail link: https://testrail.stage.mozaws.net/index.php?/cases/view/76177

Preconditions: Visit multiple websites and populate Top Sites area.(a restart is needed for the Top Sites to be populated or they will appear by themselves after 15 minutes)

Steps:
1. Hover one of the Top Sites tiles and click the "(...)" button
2. Click the "Dismiss" option
3. Observe the Top Sites tiles
4. Refresh the New Tab page
5. Restart the browser and observe the New Tab page

Expected results:
Step 1:
A sub-menu is displayed with the following options:
- Pin
- Open in a New Window
- Open in a Private Window
- Dismiss
- Delete from History
Step 2:
The website is dismissed from Top Sites section.
Website is not removed from History.
Step 3:	
The tile that is next in queue has replaced the dismissed one.
Step 4:
The dismissed top site is no longer displayed.
Step 5:	
The dismissed top site is no longer displayed.

Comment 1

[Ioana Crisan]

Attachment: dismissTopSite

Comment 2

[Ioana Crisan]

TRY results: https://treeherder.mozilla.org/#/jobs?repo=try&revision=36ed9879d3ba3b02fdcf36bcfe025773ab26fa1d

Comment 3

[Ed Lee :Mardak]

Comment on attachment 8953774 [details] [diff] [review]
dismissTopSite

ursula, both this test and bug 1441570 have hardcoded references to "youtube" etc. That seems a bit cumbersome to update if we do have changes, but I suppose maybe we won't be changing them much anyway. ;)

Additionally, this test has the explicit check for menu options of specific text at specific positions. If we have more tests doing this, any position changing of options, which seems a more likely type of change, would require updating all of these tests.

Comment 4

[Ed Lee :Mardak]

Oh, and r?ursula so your call! ;)

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4024

Comment 6

[Ursula Sarracini (:ursula)]

Comment on attachment 8953774 [details] [diff] [review]
dismissTopSite

Moved to github. Will review there. Thanks!

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4036

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/ead5539e4f49d87d3e61d8417258e78cea5fa7ba
Fix Bug 1410828 - Add a test to verify that the next top site in queue replaces a dismissed top site

Comment 9

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/4183020e7017