1410885 - Implement border/padding helpers

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement, P1)

Description

[Martin Stránský [:stransky] (ni? me)]

Add MOZ_GTK_HEADER_BAR* widgets tp moz_gtk_get_widget_border()

Comment 1

[Martin Stránský [:stransky] (ni? me)]

We actually have the border/padding getters here so let's commit the helpers at least.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1410885 - Implement border/padding helpers,

Review commit: https://reviewboard.mozilla.org/r/192000/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192000/

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1410885 - Use helpers for MOZ_GTK_HEADER_BAR* widgets,

Review commit: https://reviewboard.mozilla.org/r/192002/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192002/

Comment 4

[Jan Horak [:jhorak]]

Comment on attachment 8921040 [details]
Bug 1410885 - Implement border/padding helpers,

https://reviewboard.mozilla.org/r/192000/#review197212

r+ with that fixed.

::: widget/gtk/gtk3drawing.cpp:57
(Diff revision 1)
> +static void moz_gtk_add_margin_border_padding(GtkStyleContext *style,
> +                                              gint* left, gint* top,
> +                                              gint* right, gint* bottom);
> +static void moz_gtk_add_border_padding(GtkStyleContext *style,
> +                                       gint* left, gint* top,
> +                                       gint* right, gint* bottom);

Instead of using declaration please move the implementation here.

::: widget/gtk/gtk3drawing.cpp:2208
(Diff revision 1)
>  
>              *left = *top = *right = *bottom = gtk_container_get_border_width(GTK_CONTAINER(w));
> -            moz_gtk_add_style_border(style,
> +            moz_gtk_add_border_padding(style,
> -                                     left, top, right, bottom);
> -            moz_gtk_add_style_padding(style,
> -                                      left, top, right, bottom);
> +                                       left, top, right, bottom);

nit: when touching this, this can stay on the same line with moz_gtk_add_border_padding. It's still in the 80 chars per line.

Comment 5

[Jan Horak [:jhorak]]

Comment on attachment 8921041 [details]
Bug 1410885 - Use helpers for MOZ_GTK_HEADER_BAR* widgets,

https://reviewboard.mozilla.org/r/192002/#review197230

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8921040 [details]
Bug 1410885 - Implement border/padding helpers,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/192000/diff/1-2/

Comment 7

[Jan Horak [:jhorak]]

Comment on attachment 8921040 [details]
Bug 1410885 - Implement border/padding helpers,

https://reviewboard.mozilla.org/r/192000/#review198138

Thank you!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89dfd44fcfd4
Implement border/padding helpers, r=jhorak

Comment 9

[Attila Craciun [:arny]]

https://hg.mozilla.org/mozilla-central/rev/89dfd44fcfd4