Closed Bug 1410919 Opened 3 years ago Closed 3 years ago

Remove Flush in UpdateDestinationFrom

Categories

(Core :: Graphics: Layers, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: rhunt, Assigned: rhunt)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

From a discussion with Nical on irc, the draw target flushes in UpdateDestinationFrom may not be necessary [1]. After bug 1409871, this is used for also copying the old back buffer to the new back buffer, so it would be nice if we could remove it.

[1] http://searchfox.org/mozilla-central/rev/8a6a6bef7c54425970aa4fb039cc6463a19c0b7f/gfx/layers/client/ContentClient.cpp#701
I've done some try runs with this patch and never seen a problem so I think it should be fine.

e.g.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c9fd4693e79fc587f3cd99385256d32390f480e
Comment on attachment 8923941 [details]
Remove flush from RotatedBuffer::UpdateDestinationFrom (bug 1410919, )

https://reviewboard.mozilla.org/r/195122/#review201810
Attachment #8923941 - Flags: review?(nical.bugzilla) → review+
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0afee55b7f4f
Remove flush from RotatedBuffer::UpdateDestinationFrom (bug 1410919, r=nical)
https://hg.mozilla.org/mozilla-central/rev/0afee55b7f4f
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.