1410933 - segmentation fault when using show_bug.cgi and other bugzilla CGI

Status: UNCONFIRMED

(Bugzilla :: Bugzilla-General, defect)

Description

[loic.lefort]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20170926190823

Steps to reproduce:

From time to time, when showing a bug, user gets a blank screen.
When looking on server we see show_bug.cgi process ended with segmentation fault.

After investigation, problem was caused by file Bugzilla/Util.pm, line 605:
    my $dt = new DateTime(\%args);
while DateTime is expecting a hash as arguments (instead of a ref).


Actual results:

We were using an old version of DateTime module (version 1.18).
We have upgraded DateTime to latest version (1.44 when writing this text) and we have no more segmentation fault.


Expected results:

Check of arguments in DateTime was improved so we have no more segmentation fault, but arguments to DateTime are still incorrect and line would better be replaced by
    my $dt = new DateTime(%args);

Optionally, checksetup.pl --check-module could verify DateTime module is present with a recent version. I would propose version 1.38 that is first non-trial release including new validation mechanism.