1410938 - Split the clang-format calls

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, enhancement, P3)

Description

[Sylvestre Ledru [:Sylvestre]]

./mach clang-format -p . 
will reformat the whole source code.
However, we can probably reach the max command line size.

Instead, I propose that we split the call to clang-format per batch of XXX files.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1410938 - Split the clang-format calls into batches of 200 files

Review commit: https://reviewboard.mozilla.org/r/192118/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192118/

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1410938 - Make mach_commands.py flake8/pep8 compatible and add it the list of flake8 files

Review commit: https://reviewboard.mozilla.org/r/192120/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192120/

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8921128 [details]
Bug 1410938 - Split the clang-format calls into batches of 200 files

https://reviewboard.mozilla.org/r/192118/#review197302

I'm pretty sure there's an `itertools` helper to do the chunking. But this is fine.

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8921129 [details]
Bug 1410938 - Make mach_commands.py flake8/pep8 compatible and add it the list of flake8 files

https://reviewboard.mozilla.org/r/192120/#review197304

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bac298708923
Split the clang-format calls into batches of 200 files r=gps
https://hg.mozilla.org/integration/autoland/rev/7b07d5488288
Make mach_commands.py flake8/pep8 compatible and add it the list of flake8 files r=gps

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bac298708923
https://hg.mozilla.org/mozilla-central/rev/7b07d5488288