Closed
Bug 1411011
Opened 7 years ago
Closed 7 years ago
Context menu offers to pin or remove private browsing icon and titlebar placeholders
Categories
(Firefox :: Toolbars and Customization, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 58
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox56 | --- | unaffected |
firefox57 | --- | wontfix |
firefox58 | --- | verified |
People
(Reporter: Oriol, Assigned: Gijs)
Details
(Keywords: polish, regression, Whiteboard: [reserve-photon-structure])
Attachments
(1 file)
Open a private window.
Right-click the private browsing icon. The browser console shows
Error: No nodes without ids that aren't special widgets should ever come into contact with CUI
Click "Pin to Overflow Menu". The browser console shows
CustomizableUI:findWidgetInWindow was passed an empty string.
CustomizableUI:Widget '' not found, unable to move
Or click "Remove from Toolbar". The browser console shows
CustomizableUI:findWidgetInWindow was passed an empty string.
CustomizableUI:Widget not found, unable to remove from widget-overflow-fixed-list
Empty string passed to getElementById().
Comment 1•7 years ago
|
||
Can you try to find a regression window for this? (I assume it's a regression?)
status-firefox57:
--- → affected
Flags: needinfo?(oriol-bugzilla)
Keywords: regression,
regressionwindow-wanted
Reporter | ||
Comment 2•7 years ago
|
||
I tried but it was hard, because some versions had the problem when you clicked just at the left of the icon but not on it. Or only when you enabled the title bar. So it was hard to decide whether a version was good or bad.
Flags: needinfo?(oriol-bugzilla)
Comment 3•7 years ago
|
||
Hm, can you try to narrow it down a little further? I can also take a look at this later, I've been able to reproduce on Windows 10.
OS: Unspecified → Windows
Hardware: Unspecified → All
Comment 4•7 years ago
|
||
I agree, it's really confusing.
When I do a mozregression based on the strict criterium: "Does the private mode indicator have a functioning Pin to Overflow Menu item in the context menu", it gives me a push range that shows bug 1403867 as the regressor. But, as you were mentioning, this problem has manifested in some ways before that patch came around and I think the patch was just unlucky to make the weird context menu appear on the private browsing indicator.
I wonder if the Photon structure team can help us with this.
Blocks: 1403867
status-firefox56:
--- → unaffected
status-firefox58:
--- → affected
Flags: qe-verify+
Keywords: regressionwindow-wanted
Whiteboard: [photon-structure][triage]
Reporter | ||
Comment 5•7 years ago
|
||
By the way, I noticed this also happens if you right-click the drag space at the right of the tabbar, or the accessibility icon (it will appear if you use Windows' on-screen keyboard).
Comment 6•7 years ago
|
||
Ah, true, I guess this is because we fail to disable these menu items on titlebar-placeholder elements. It's probably not right to block bug 1403867 then.
No longer blocks: 1403867
Summary: Context menu offers to pin or remove private browsing icon → Context menu offers to pin or remove private browsing icon and titlebar placeholders
Updated•7 years ago
|
Component: Theme → Toolbars and Customization
Updated•7 years ago
|
Whiteboard: [photon-structure][triage] → [reserve-photon-structure]
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Updated•7 years ago
|
Priority: P3 → P1
Comment hidden (mozreview-request) |
Comment 8•7 years ago
|
||
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8925547 [details]
Bug 1411011 - stop offering context menu (re)move options on skipintoolbarset items,
https://reviewboard.mozilla.org/r/196670/#review201958
dang, i'm mad that we missed this for photon.
Attachment #8925547 -
Flags: review?(jaws) → review+
Comment 10•7 years ago
|
||
adding on to comment 9, it's OK that it misses 57 it just would have been nice to fix this since it's so simple. we'll be ok with this bug in 57.
Comment 11•7 years ago
|
||
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/62b4fc74e72e
stop offering context menu (re)move options on skipintoolbarset items, r=jaws
Comment 12•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment 13•7 years ago
|
||
I tested this issue using Latest Nightly 58.0a1 on Windows 10 x64 and Windows 7 x64 with Build ID 20171109220104. During the verification found that, when I right-click on the persistent drag space of private icon the "pin to overflow menu" and "remove from toolbar" are disabled. This is the expected behavior?
Flags: needinfo?(gijskruitbosch+bugs)
Assignee | ||
Comment 14•7 years ago
|
||
(In reply to Valentina Claudia Ona from comment #13)
> I tested this issue using Latest Nightly 58.0a1 on Windows 10 x64 and
> Windows 7 x64 with Build ID 20171109220104. During the verification found
> that, when I right-click on the persistent drag space of private icon the
> "pin to overflow menu" and "remove from toolbar" are disabled. This is the
> expected behavior?
Yes.
Flags: needinfo?(gijskruitbosch+bugs)
Updated•7 years ago
|
status-firefox-esr52:
--- → unaffected
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•