1411011 - Context menu offers to pin or remove private browsing icon and titlebar placeholders

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Oriol Brufau [:Oriol]]

Open a private window.

Right-click the private browsing icon. The browser console shows
    Error: No nodes without ids that aren't special widgets should ever come into contact with CUI

Click "Pin to Overflow Menu". The browser console shows
    CustomizableUI:findWidgetInWindow was passed an empty string.
    CustomizableUI:Widget '' not found, unable to move

Or click "Remove from Toolbar". The browser console shows
    CustomizableUI:findWidgetInWindow was passed an empty string.
    CustomizableUI:Widget  not found, unable to remove from widget-overflow-fixed-list
    Empty string passed to getElementById().

Comment 1

[Johann Hofmann [:johannh]]

Can you try to find a regression window for this? (I assume it's a regression?)

Comment 2

[Oriol Brufau [:Oriol]]

I tried but it was hard, because some versions had the problem when you clicked just at the left of the icon but not on it. Or only when you enabled the title bar. So it was hard to decide whether a version was good or bad.

Comment 3

[Johann Hofmann [:johannh]]

Hm, can you try to narrow it down a little further? I can also take a look at this later, I've been able to reproduce on Windows 10.

Comment 4

[Johann Hofmann [:johannh]]

I agree, it's really confusing.

When I do a mozregression based on the strict criterium: "Does the private mode indicator have a functioning Pin to Overflow Menu item in the context menu", it gives me a push range that shows bug 1403867 as the regressor. But, as you were mentioning, this problem has manifested in some ways before that patch came around and I think the patch was just unlucky to make the weird context menu appear on the private browsing indicator.

I wonder if the Photon structure team can help us with this.

Comment 5

[Oriol Brufau [:Oriol]]

By the way, I noticed this also happens if you right-click the drag space at the right of the tabbar, or the accessibility icon (it will appear if you use Windows' on-screen keyboard).

Comment 6

[Johann Hofmann [:johannh]]

Ah, true, I guess this is because we fail to disable these menu items on titlebar-placeholder elements. It's probably not right to block bug 1403867 then.

Comment 7

[:Gijs (he/him)]

Attachment: Bug 1411011 - stop offering context menu (re)move options on skipintoolbarset items,

Giving all these nodes ids doesn't seem like the right fix. `buildArea` already ignores skipintoolbarset
items before doing anything else with nodes, so bailing out early seemed like the right solution here.

Review commit: https://reviewboard.mozilla.org/r/196670/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196670/

Comment 8

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bugmasters/Projects/Bug_Handling/Bug_Husbandry#Move_fix-optionals

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8925547 [details]
Bug 1411011 - stop offering context menu (re)move options on skipintoolbarset items,

https://reviewboard.mozilla.org/r/196670/#review201958

dang, i'm mad that we missed this for photon.

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

adding on to comment 9, it's OK that it misses 57 it just would have been nice to fix this since it's so simple. we'll be ok with this bug in 57.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62b4fc74e72e
stop offering context menu (re)move options on skipintoolbarset items, r=jaws

Comment 12

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/62b4fc74e72e

Comment 13

[Valentina Claudia Ona]

I tested this issue using Latest Nightly 58.0a1 on Windows 10 x64 and Windows 7 x64 with Build ID 20171109220104. During the verification found that, when  I right-click on the persistent drag space of private icon the "pin to overflow menu" and "remove from toolbar" are disabled. This is the expected behavior?

Comment 14

[:Gijs (he/him)]

(In reply to Valentina Claudia Ona from comment #13)
> I tested this issue using Latest Nightly 58.0a1 on Windows 10 x64 and
> Windows 7 x64 with Build ID 20171109220104. During the verification found
> that, when  I right-click on the persistent drag space of private icon the
> "pin to overflow menu" and "remove from toolbar" are disabled. This is the
> expected behavior?

Yes.