1411069 - Port |Bug 1313150 - Remove |weak| parameter from nsIMutableArray methods| to mailnews

Status: RESOLVED FIXED

(MailNews Core :: Backend, enhancement)

Description

[Jorg K (CEST = GMT+2)]

Here is how it's done:
https://hg.mozilla.org/mozilla-central/rev/26c7003f1546

Affects AppendElement() and ReplaceElementAt().

A lot of usage in C-C, so this will need to remain busted until tomorrow.

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1411069-nsIMutableArray.patch

This only covers ReplaceElementAt().

Comment 2

[Jorg K (CEST = GMT+2)]

find mail -name *.cpp -exec sed -i -e 's/AppendElement(\(.*\), false/AppendElement(\1/' {} \;
also run on mailnews, ldap and suite.

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1411069-nsIMutableArray.patch (v2)

Comment 4

[Jorg K (CEST = GMT+2)]

Attachment: 1411069-nsIMutableArray.patch (v3)

Covering InsertElementAt() as well.

Comment 5

[Jorg K (CEST = GMT+2)]

Attachment: 1411069-js.patch

JS part

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c38974cf236e
Port bug 1313150 to mailnews: Remove |weak| parameter from nsIMutableArray methods. rs=bustage-fix
https://hg.mozilla.org/comm-central/rev/dd1d559aeb26
Port bug 1313150 to mailnews: Remove |weak| parameter from nsIMutableArray methods (JS part). rs=bustage-fix

Comment 7

[Jorg K (CEST = GMT+2)]

Fingers crossed I didn't miss anything. The C++ part seems to compile so far.
Sadly the commit message isn't quite right since the patches hit calendar/, im/, mail/, mailnews/, ldap/ and suite/, but the bulk was in mailnews/.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6f2de28da2f1
Port bug 1313150, follow-up: Remove |weak| parameter from nsIMutableArray methods (ldap, suite). r=jorgk

Comment 9

[Jorg K (CEST = GMT+2)]

I had missed a few which Edmund fixed in bug 1411127, but I landed it here to keep things together.