Closed Bug 1411069 Opened 6 years ago Closed 6 years ago

Port |Bug 1313150 - Remove |weak| parameter from nsIMutableArray methods| to mailnews

Categories

(MailNews Core :: Backend, enhancement)

Product:
MailNews Core
Component:
Backend
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 58.0

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

References

Details

Attachments

(2 files, 2 obsolete files)

1411069-nsIMutableArray.patch (v3)
109.44 KB, patch
Details | Diff | Splinter Review
1411069-js.patch
120.76 KB, patch
Details | Diff | Splinter Review 
Here is how it's done:
https://hg.mozilla.org/mozilla-central/rev/26c7003f1546

Affects AppendElement() and ReplaceElementAt().

A lot of usage in C-C, so this will need to remain busted until tomorrow.
Attached patch 1411069-nsIMutableArray.patch (obsolete) — — Splinter Review 
This only covers ReplaceElementAt().
find mail -name *.cpp -exec sed -i -e 's/AppendElement(\(.*\), false/AppendElement(\1/' {} \;
also run on mailnews, ldap and suite.
Assignee: nobody → jorgk

        Attachment #8921246 -
        Attachment is obsolete: true
Status: NEW → ASSIGNED

    
    

    
  


  
Covering InsertElementAt() as well.

        Attachment #8921254 -
        Attachment is obsolete: true

    
    

    
  

      
      
      
      

        Attached patch
          
          
        1411069-js.patch
        — 
          — Splinter Review
      

    


  
JS part

    
    

    
  
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/c38974cf236e
Port bug 1313150 to mailnews: Remove |weak| parameter from nsIMutableArray methods. rs=bustage-fix
https://hg.mozilla.org/comm-central/rev/dd1d559aeb26
Port bug 1313150 to mailnews: Remove |weak| parameter from nsIMutableArray methods (JS part). rs=bustage-fix
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED

    
    

    
  
Fingers crossed I didn't miss anything. The C++ part seems to compile so far.
Sadly the commit message isn't quite right since the patches hit calendar/, im/, mail/, mailnews/, ldap/ and suite/, but the bulk was in mailnews/.
Target Milestone: --- → Thunderbird 58.0
Version: 52 → Trunk
Blocks: 1411127

    
    

    
  
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/6f2de28da2f1
Port bug 1313150, follow-up: Remove |weak| parameter from nsIMutableArray methods (ldap, suite). r=jorgk

    
    

    
  
I had missed a few which Edmund fixed in bug 1411127, but I landed it here to keep things together.

          You need to log in
          before you can comment on or make changes to this bug.