1411093 - test_TelemetryLog.js is going to permafail when Gecko 58 merges to Beta on 2017-11-02

Status: VERIFIED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Permafailing tests on Android on the next merge day.

I haven't bisected to prove it yet, but I strongly suspect bug 1406392 is the culprit. Can you please take a look, Alessio?

https://treeherder.mozilla.org/logviewer.html#?job_id=139041974&repo=try

toolkit/components/telemetry/tests/unit/test_TelemetryLog.js | JavaScript strict warning: resource://gre/modules/TelemetrySession.jsm, line 69: ReferenceError: reference to undefined property "_sessionStartDate"
Unexpected exception TypeError: date is undefined at resource://gre/modules/TelemetryUtils.jsm:1
truncateToHours@resource://gre/modules/TelemetryUtils.jsm:1:2384
getMetadata@resource://gre/modules/TelemetrySession.jsm:69:110
getSessionPayload@resource://gre/modules/TelemetrySession.jsm:113:137
getPayload@resource://gre/modules/TelemetrySession.jsm:152:28
getPayload@resource://gre/modules/TelemetrySession.jsm:36:195
@test_TelemetryLog.js:37:13
_do_main@/storage/sdcard/tests/xpc/head.js:221:3
_execute_test@/storage/sdcard/tests/xpc/head.js:544:5

If you want to try reproducing locally, the first patch below will probably suffice. If not, try adding the second one on top of it.
https://hg.mozilla.org/try/rev/aa2fb4ca91a4ff5568570e0ed97e5ca57fa42c37
https://hg.mozilla.org/try/rev/7c6f3531aec31573aa226c78ad6933631c5bf512

Comment 1

[Alessio Placitelli [:Dexter]]

Yes, looks like it's related.

Comment 2

[Alessio Placitelli [:Dexter]]

Attachment: Bug 1411093 - Set the correct Telemetry pref when running tests on Android.

Non unified telemetry needs "toolkit.telemetry.enabled" to be set to true
in order for Telemetry to be collected at all.

Review commit: https://reviewboard.mozilla.org/r/192526/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192526/

Comment 3

[Chris H-C :chutten]

Comment on attachment 8921495 [details]
Bug 1411093 - Set the correct Telemetry pref when running tests on Android.

https://reviewboard.mozilla.org/r/192526/#review197704

Shouldn't we be checking Services.prefs.getBoolPref(TelemetryUtils.Preferences.Unified, false) instead of gIsAndroid, just in case?

Comment 4

[Alessio Placitelli [:Dexter]]

Comment on attachment 8921495 [details]
Bug 1411093 - Set the correct Telemetry pref when running tests on Android.

https://reviewboard.mozilla.org/r/192526/#review197704

Good point, changed that!

Comment 5

[Alessio Placitelli [:Dexter]]

Comment on attachment 8921495 [details]
Bug 1411093 - Set the correct Telemetry pref when running tests on Android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/192526/diff/1-2/

Comment 6

[Alessio Placitelli [:Dexter]]

The try push for this lives here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a703fc020333806376ca3849c2dfdce284c5ee8

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b8628840dfe
Set the correct Telemetry pref when running tests on Android. r=chutten

Comment 8

[Attila Craciun [:arny]]

Backed out 1 changesets (bug 1411093) for failing xpcshell in toolkit/components/telemetry/tests/unit/test_TelemetryLog.js r=backout on a CLOSED TREE. 

https://hg.mozilla.org/integration/autoland/rev/8a5139bdc689e1924b302e4c2ec27b03abc05ce6

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2b8628840dfefdb68498e948f69fdb313b0037b6&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception

Comment 9

[Alessio Placitelli [:Dexter]]

Comment on attachment 8921495 [details]
Bug 1411093 - Set the correct Telemetry pref when running tests on Android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/192526/diff/2-3/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21c278929088
Set the correct Telemetry pref when running tests on Android. r=chutten

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/21c278929088