Closed Bug 1411236 Opened 2 years ago Closed 2 years ago

Conflicting sidebar search bar padding rules on Windows

Categories

(Firefox :: Theme, defect, P1)

57 Branch
Unspecified
Windows
defect

Tracking

()

VERIFIED FIXED
Firefox 58
Tracking Status
firefox57 --- verified
firefox58 --- verified

People

(Reporter: nhnt11, Assigned: nhnt11)

References

Details

(Whiteboard: [reserve-photon-visual])

Attachments

(1 file)

:(

Uploading a patch, though it's probably too late to uplift to 57.
I didn't write much of a bug description because the title gives most of the information, but here are some details:

We increased the padding around the searchbar in bug 1400165 but I missed the fact that Windows already had a rule for this, and added the new rule near the top of the stylesheet. The older rule was further down, so the new rule gets overridden.
Summary: Conflicting sidebar search bar margin rules on Windows → Conflicting sidebar search bar padding rules on Windows
Comment on attachment 8921434 [details]
Bug 1411236 - Conflicting sidebar search bar padding rules on Windows.

https://reviewboard.mozilla.org/r/192462/#review197614
Attachment #8921434 - Flags: review?(dao+bmo) → review+
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/fc51ba0a7e8d
Conflicting sidebar search bar padding rules on Windows. r=dao
Comment on attachment 8921434 [details]
Bug 1411236 - Conflicting sidebar search bar padding rules on Windows.

Approval Request Comment
[Feature/Bug causing the regression]: photon-visual polish. Not a regression, but makes sure the change from bug 1400165 actually takes effect on Windows.
[User impact if declined]: Search bar in sidebar is a little cramped on Windows; less spacing around it. Inconsistent with MacOS and Linux.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]:
[List of other uplifts needed for the feature/fix]: bug 1400165 was already uplifted.
[Is the change risky?]: no
[Why is the change risky/not risky?]: We had one CSS rule applying 8px of padding and one applying 4px to the same element. The patch un-conflicts this rule
[String changes made/needed]: none

I realize it's pretty late but I thought I'd request uplift anyway and see what happens :)
Attachment #8921434 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/fc51ba0a7e8d
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment on attachment 8921434 [details]
Bug 1411236 - Conflicting sidebar search bar padding rules on Windows.

This is a follow up fix to bug 1400165 was triaged as a P1, Beta57+
Attachment #8921434 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
Hi Nihanth, can you please help us here and tell us how should we verify this bug? Thanks
Flags: needinfo?(nhnt11)
I verified this issue using Nightly 58.0a1 on Windows 7 x64 and Windows 10 x64 with Build ID 20171106100122.
I will mark this as verified fixed.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Flags: needinfo?(nhnt11)
I have reproduced this issue using Firefox nightly build (2017.10.24) on Win 8.1 x64.
I can confirm this issue is fixed, I verified using Firefox 57.0b14 on Win 8.1 x64.
You need to log in before you can comment on or make changes to this bug.