1411397 - error_aggregates improperly parsing displayVersion

Status: RESOLVED FIXED

(Data Platform and Tools Graveyard :: Datasets: Error Aggregates, enhancement, P1)

Description

[Frank Bertsch [:frank]]

Exception:
org.json4s.package$MappingException: No usable value for application
No usable value for displayVersion
Did not find value which can be converted into java.lang.String

Comment 1

[William Lachance (:wlach)]

Apparently "displayVersion" is not currently required by the pipeline schema.

https://github.com/mozilla-services/mozilla-pipeline-schemas/blob/961d24db526c9a0e90785ac50f3b08e6d46800b4/schemas/telemetry/main/main.4.schema.json#L39

Should it be? And if so, should we just skip pings (from older "versions" of Firefox) that don't have the value?

Comment 2

[Mark Reid [:mreid]]

Looks like it was added in Fx 46, so I think it's fine for Mission Control to skip pings that don't have it, however I don't think we can reject them at ingestion / schema validation time. 

I'm not sure if the same is true for the error aggregates dataset, but it seems unlikely we'll do anything about errors prior to 46. 

If we do want to keep these pings, we could fall back to application.version if application.displayVersion is missing.

Comment 3

[William Lachance (:wlach)]

Fixed with: https://github.com/mozilla/telemetry-streaming/pull/87