Closed
Bug 1411421
Opened 7 years ago
Closed 7 years ago
MarkOutOfFlowFrameForDisplay reduces the visible rect to the dirty rect for position:fixed content
Categories
(Core :: Web Painting, enhancement)
Core
Web Painting
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
References
Details
Attachments
(1 file)
|
887 bytes,
patch
|
mikokm
:
review+
|
Details | Diff | Splinter Review |
The fixed position branch of MarkOutOfFlowFrameForDisplay currently has a TODO, where we're setting the visible rect to match the dirty rect. With retained-dl enabled, the dirty rect (the partial rebuild rect) is likely a subset of the visible rect, and we don't want to reduce the visible rect to this. We only want to do this if we've modified dirtyRectRelativeToDirtyFrame to cover the entire visible rect (the above inner branches), so this moves that code into the right branches.
Attachment #8921652 -
Flags: review?(mikokm)
|
||
Updated•7 years ago
|
Assignee: nobody → matt.woodrow
Status: NEW → ASSIGNED
|
|
||
Updated•7 years ago
|
Attachment #8921652 -
Flags: review?(mikokm) → review+
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/68526684be41 Make MarkOutOfFlowFrameForDisplay only modifiy the visible rect when we also modified the dirty rect. r=miko
|
||
Comment 2•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/68526684be41
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•