1411439 - Pass interceptor to IHandlerProvider

Status: RESOLVED FIXED

(Core :: IPC: MSCOM, enhancement)

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Whoops, forgot description:

In some cases IHandlerProvider implementers may want to access the interceptor that owns the handler provider. We should pass a weakref into the handler provider to enable such access.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Based on discussions with Jamie, we think that the right place to pass this parameter is during payload construction, so the weakref should be added to GetHandlerPayloadSize and WriteHandlerPayload.

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Pass WeakRefs into HandlerProvider at payload generation time

Comment 4

[James Teh [:Jamie]]

Comment on attachment 8922518 [details] [diff] [review]
Pass WeakRefs into HandlerProvider at payload generation time

Thanks! This will work, but as discussed on IRC, unless there's a good reason not to do this, it'd be simpler to just pass the interceptor itself (since the call chain starts at the interceptor anyway) rather than a weak ref. We don't even need to resolve the weak ref because the interceptor can just pass itself. A weak ref made more sense when we were talking about passing it into CreateInstance, but the passed reference shouldn't outlive the payload methods, so I think the simpler path is better in this case.

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Pass Interceptor pointer into HandlerProvider at payload generation time

Comment 6

[James Teh [:Jamie]]

Comment on attachment 8922552 [details] [diff] [review]
Pass Interceptor pointer into HandlerProvider at payload generation time

Nice! Ta!

Comment 7

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e6be650fc1783f3c64642d137ae7d53052ff3b8f
Bug 1411439: Pass reference to owning interceptor into HandlerProvider for payload creation; r=Jamie

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e6be650fc178